Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bundle-lib to 0.2.3 #981

Merged
merged 2 commits into from Jun 8, 2018
Merged

Bump bundle-lib to 0.2.3 #981

merged 2 commits into from Jun 8, 2018

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Jun 7, 2018

No description provided.

@jmrodri jmrodri requested a review from shawn-hurley June 7, 2018 20:23
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 7, 2018
@jmrodri jmrodri requested a review from djzager June 7, 2018 20:23
djzager
djzager approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shawn-hurley
shawn-hurley requested changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the build is break?

@jmrodri
Copy link
Contributor Author

jmrodri commented Jun 7, 2018

@shawn-hurley sigh

$ go get -u github.com/golang/dep/cmd/dep
# github.com/golang/dep/gps
../../golang/dep/gps/constraint.go:392: undefined: sort.SliceStable
../../golang/dep/gps/constraint.go:411: undefined: sort.SliceStable
../../golang/dep/gps/lock.go:55: undefined: sort.SliceIsSorted
../../golang/dep/gps/lock.go:62: undefined: sort.Slice
The command "go get -u github.com/golang/dep/cmd/dep" exited with 2.

@jmrodri
Copy link
Contributor Author

jmrodri commented Jun 7, 2018

Well then I think I pushed up something that is actually broken :)

@jmrodri jmrodri merged commit d6185b9 into master Jun 8, 2018
@jmrodri jmrodri deleted the bump-bundle-lib branch June 8, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmrodri @djzager @shawn-hurley @openshift-ci-robot