Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie broker apb #986

Merged
merged 5 commits into from Jun 14, 2018
Merged

Tie broker apb #986

merged 5 commits into from Jun 14, 2018

Conversation

djzager
Copy link
Member

@djzager djzager commented Jun 13, 2018

This automates the process of building an APB that is tied directly to a specific version of the broker. This should allow for automated publishing of master, release-, and ansible-service-broker- branches to dockerhub of 1) the broker 2) broker-apb that were built at the same time.

Assuming this PR is acceptable, the consequences are:

  1. A merge to master will create a new build of docker.io/ansibleplaybookbundle/origin-ansible-service-broker:canary and docker.io/automationbroker/automation-broker-apb:canary
  2. A merge to release-1.3 (future) will create a build of docker.io/ansibleplaybookbundle/origin-ansible-service-broker:release-1.3 and docker.io/automationbroker/automation-broker-apb:release-1.3 (NOTE: the dockerhub registry will be configured to look at latest)
  3. A merge to ansible-service-broker-1.3.2-1 (future) will create a build of docker.io/ansibleplaybookbundle/origin-ansible-service-broker:ansible-service-broker-1.3.2-1 and docker.io/automationbroker/automation-broker-apb:ansible-service-broker-1.3.2-1 (NOTE: the dockerhub registry will be configured to look at latest)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2018
@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage remained the same at 33.435% when pulling 2e63203 on djzager:tie-broker-apb into 5efd847 on openshift:master.

Copy link
Contributor

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from me. Asked rhallisey for a review so he's aware and on board since he cares for the travis side of things. If we get this working it'd be nice to make some changes to catasb to get back the ability to deploy different broker images.

Copy link
Contributor

@rthallisey rthallisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack from me

@djzager djzager merged commit 10e844b into openshift:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants