Pass in namespace to runtime #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
ping @shawn-hurley |
maleck13
force-pushed
the
pass-in-namespace-to-runtime
branch
from
ae8e92c
to
940c636
Compare
|
I think we need to merge this @djzager @dymurray @rthallisey you guys mind checking this out? |
shawn-hurley
approved these changes
Jun 15, 2018
djzager
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
the namespace for the broker can change. So ensure it is passed through to the runtime package at startup.
While testing some state changes, I noticed state was not being saved this was due to the fact it was expecting to save to the ns ansible-service-broker.
While running make check I noticed that several tests were failing due to compilation errors so I fixed these also.