Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app registry image search job #1808

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@adammhaile
Copy link
Contributor

commented Apr 23, 2019

No description provided.

'aos-team-art@redhat.com',
].join(',')
],
commonlib.mockParam(),

This comment has been minimized.

Copy link
@tbielawa

This comment has been minimized.

Copy link
@adammhaile

adammhaile Apr 23, 2019

Author Contributor

Which is already done as part of buildlib.initialize(false)

DOOZER_WORKING = "${env.WORKSPACE}/doozer_working"
buildlib.cleanWorkdir(DOOZER_WORKING)

currentBuild.description = "Collecting appregistry images for ${params.BUILD_VERSION}"

This comment has been minimized.

Copy link
@tbielawa

tbielawa Apr 23, 2019

Member

You set the description to something you were gonna do, but never set it later to say that you did the thing

This comment has been minimized.

Copy link
@adammhaile

adammhaile Apr 23, 2019

Author Contributor

Added

currentBuild.description = "Collecting appregistry images for ${params.BUILD_VERSION}"

try {
successful = []

This comment has been minimized.

Copy link
@tbielawa

tbielawa Apr 23, 2019

Member

What is this?

This comment has been minimized.

Copy link
@adammhaile

adammhaile Apr 23, 2019

Author Contributor

Left over :P will remove

stage("fetch appregistry images") {
buildlib.doozer "--working-dir ${DOOZER_WORKING} --group 'openshift-${params.BUILD_VERSION}' images:print --label 'com.redhat.delivery.appregistry' --short '{label},{name},{build},{version}' | tee ${env.WORKSPACE}/appreg.list"

sh "python appreg.py ${env.WORKSPACE}/appreg.list ${env.WORKSPACE}/appreg.yaml"

This comment has been minimized.

Copy link
@tbielawa

tbielawa Apr 23, 2019

Member

Can you have this cat out the generated file before this stage finishes?

Then update the description to say that it did the needful.

This comment has been minimized.

Copy link
@adammhaile

adammhaile Apr 23, 2019

Author Contributor

That's already done by | tee ${env.WORKSPACE}/appreg.list
It's emitted to the console as it runs.

to: "${params.MAIL_LIST_FAILURE}",
from: "aos-team-art@redhat.com",
subject: "Unexpected error during OCP Merge!",
body: "Encountered an unexpected error while running OCP merge: ${err}"

This comment has been minimized.

Copy link
@tbielawa

tbielawa Apr 23, 2019

Member

After this would probably be a good spot to update currentBuild.description to say something like "it failed, sorry!"

This comment has been minimized.

Copy link
@adammhaile

adammhaile Apr 23, 2019

Author Contributor

added

@adammhaile adammhaile force-pushed the adammhaile:ART-455 branch from fa1d1fc to 3f8a42a Apr 23, 2019

@tbielawa

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

/lgtm

@tbielawa tbielawa merged commit c5255aa into openshift:master Apr 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.