Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring multiarch support to the build-sync job #1991

Merged

Conversation

@tbielawa
Copy link
Member

commented Oct 10, 2019

Supporting work for https://jira.coreos.com/browse/ART-837 "configure
per-arch processes for creating a nightly release image"

@tbielawa tbielawa force-pushed the tbielawa:2019-10-10-multi-arch-build-sync branch 5 times, most recently from da51c4e to f31988c Oct 15, 2019
@tbielawa tbielawa changed the title [WIP] Bring multiarch support to the build-sync job Bring multiarch support to the build-sync job Oct 17, 2019
Copy link
Member

left a comment

I like the direction, hope I get time to dig further later.
It might have been nice to have one commit for "extract stuff to build.groovy" and one commit for the substantial changes!

@@ -18,105 +19,80 @@ node {
[
$class : 'ParametersDefinitionProperty',
parameterDefinitions: [
commonlib.suppressEmailParam(),

This comment has been minimized.

Copy link
@sosiouxme
def ocFmtStr = "registry.reg-aws.openshift.com:443/{repository}=quay.io/openshift-release-dev/ocp-v4.0-art-dev:{version}-{release}-{image_name_short}"

buildlib.cleanWorkdir(mirrorWorking)
commonlib.checkMock()

This comment has been minimized.

Copy link
@sosiouxme

sosiouxme Oct 18, 2019

Member

👍 good grief

Supporting work for https://jira.coreos.com/browse/ART-837 "configure
per-arch processes for creating a nightly release image"
@tbielawa tbielawa force-pushed the tbielawa:2019-10-10-multi-arch-build-sync branch from f31988c to ed215fa Oct 18, 2019
@tbielawa tbielawa merged commit b1a8503 into openshift:master Oct 18, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.