Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry and pause when repairing/sweeping bugs #2164

Merged

Conversation

@tbielawa
Copy link
Member

tbielawa commented Mar 19, 2020

Re: https://issues.redhat.com/browse/ART-1677

Sometimes the bugzilla API flakes out and gives us a network proxy
error. So, let's just retry the call a few times, give it a minute
between attempts just to be safe.

@tbielawa tbielawa requested review from thiagoalessio and joepvd Mar 19, 2020
@tbielawa tbielawa force-pushed the tbielawa:2020-03-19-retry-sweep-job-bz-fails branch from 39f099f to 079d41b Mar 19, 2020
@tbielawa

This comment has been minimized.

Copy link
Member Author

tbielawa commented Mar 19, 2020

@joepvd OK, I think I got it like you were saying to try out. What do you think now?

Copy link
Contributor

joepvd left a comment

Would like to keep the description as succinct as possible, and use the build log for progress logging :)

throw elliottErr
retry (3) {
try {
currentBuild.description += "* Moving attached bugs in MODIFIED state to ON_QA...\n"

This comment has been minimized.

Copy link
@joepvd

joepvd Mar 20, 2020

Contributor

This can:

  • end up in build log
  • before the retry block, so it only shows once
buildlib.elliott "--group=openshift-${version} repair-bugs --use-default-advisory ${kind} --auto"
} catch (elliottErr) {
sleep(time: 1, unit: 'MINUTES')
currentBuild.description += "Error repairing (will retry a few times):\n${elliottErr}"

This comment has been minimized.

Copy link
@joepvd

joepvd Mar 20, 2020

Contributor

Just log the retry. No need for it to end up in the description.

@sosiouxme

This comment has been minimized.

Copy link
Member

sosiouxme commented Mar 23, 2020

Second joep's advice to not have retries add to build description.

Otherwise, LGTM

@tbielawa tbielawa force-pushed the tbielawa:2020-03-19-retry-sweep-job-bz-fails branch from 079d41b to 56cd836 Mar 25, 2020
@tbielawa

This comment has been minimized.

Copy link
Member Author

tbielawa commented Mar 25, 2020

Moved the retries and description around a bit. Should be good to go now!

Re: https://issues.redhat.com/browse/ART-1677

Sometimes the bugzilla API flakes out and gives us a network proxy
error. So, let's just retry the call a few times, give it a minute
between attempts just to be safe.
@tbielawa tbielawa merged commit 8101f80 into openshift:master Mar 25, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.