Skip to content

Conversation

@ingvagabund
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2023

@ingvagabund: This pull request references WRKLDS-753 which is a valid jira issue.

In response to this:

To mention the deprecation under https://docs.openshift.com/container-platform/4.13/rest_api/workloads_apis/deploymentconfig-apps-openshift-io-v1.html as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2023

Hello @ingvagabund! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@ingvagabund
Copy link
Member Author

/hold
for docs team to review

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 10, 2023
@openshift-ci openshift-ci bot requested review from mfojtik and soltysh June 10, 2023 09:58
@ingvagabund ingvagabund force-pushed the apps-api-deprecation-in-openshift-api-docs branch from 6bcf34d to fa07e3a Compare June 10, 2023 10:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2023

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

I'm not going to be too picky in what we say here, especially since deployments aren't a 1:1 replacement of DCs. This conveys enough in saying that DCs are deprecated and points users toward deployments. We can get into some more specifics when we do the release notes/other deprecation warnings in the docs.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@ingvagabund
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 12, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergerhoffer, deads2k, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit be09f89 into openshift:master Jun 12, 2023
@ingvagabund ingvagabund deleted the apps-api-deprecation-in-openshift-api-docs branch June 12, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants