-
Notifications
You must be signed in to change notification settings - Fork 581
WRKLDS-753: DeploymentConfigs deprecation in API reference docs #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-753: DeploymentConfigs deprecation in API reference docs #1489
Conversation
|
@ingvagabund: This pull request references WRKLDS-753 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @ingvagabund! Some important instructions when contributing to openshift/api: |
|
/hold |
6bcf34d to
fa07e3a
Compare
|
@ingvagabund: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I'm not going to be too picky in what we say here, especially since deployments aren't a 1:1 replacement of DCs. This conveys enough in saying that DCs are deprecated and points users toward deployments. We can get into some more specifics when we do the release notes/other deprecation warnings in the docs. /lgtm |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergerhoffer, deads2k, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To mention the deprecation under https://docs.openshift.com/container-platform/4.13/rest_api/workloads_apis/deploymentconfig-apps-openshift-io-v1.html as well.