Skip to content

WIP: SPLAT-1790: allow additional tags to be specified in a failure domain #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: SPLAT-1790: allow additional tags to be specified in a failure domain #2025

wants to merge 2 commits into from

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Sep 11, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2024 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

Hello @rvanderp3! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2024
@openshift-ci openshift-ci bot requested review from bparees and jkyros September 11, 2024 18:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rvanderp3
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build e5ffa80 link true /test build
ci/prow/okd-scos-images e5ffa80 link true /test okd-scos-images
ci/prow/e2e-upgrade e5ffa80 link true /test e2e-upgrade
ci/prow/verify-client-go e5ffa80 link true /test verify-client-go
ci/prow/verify-crd-schema e5ffa80 link true /test verify-crd-schema
ci/prow/e2e-upgrade-out-of-change e5ffa80 link true /test e2e-upgrade-out-of-change
ci/prow/lint e5ffa80 link true /test lint
ci/prow/unit e5ffa80 link true /test unit
ci/prow/verify-deps e5ffa80 link true /test verify-deps
ci/prow/verify e5ffa80 link true /test verify
ci/prow/verify-feature-promotion e5ffa80 link true /test verify-feature-promotion
ci/prow/minor-images e5ffa80 link true /test minor-images
ci/prow/integration e5ffa80 link true /test integration
ci/prow/e2e-aws-serial-techpreview e5ffa80 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview e5ffa80 link true /test e2e-aws-ovn-techpreview
ci/prow/minor-e2e-upgrade-minor e5ffa80 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn e5ffa80 link true /test e2e-aws-ovn
ci/prow/images e5ffa80 link true /test images
ci/prow/e2e-aws-ovn-hypershift e5ffa80 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial e5ffa80 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-hypershift-conformance e5ffa80 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-techpreview-1of2 e5ffa80 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-techpreview-2of2 e5ffa80 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-1of2 e5ffa80 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-serial-2of2 e5ffa80 link true /test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Aug 14, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Sep 5, 2025

@rvanderp3 Is this something you are planning to continue?

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Sep 5, 2025

@rvanderp3 Is this something you are planning to continue?

at this time, no. I'll close this out for now.

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Sep 5, 2025

/close

@openshift-ci openshift-ci bot closed this Sep 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@rvanderp3: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@jkyros jkyros Awaiting requested review from jkyros

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rvanderp3 @openshift-ci-robot @openshift-merge-robot @openshift-bot @JoelSpeed