Skip to content

WIP: SPLAT-1790: allow additional tags to be specified in a failure domain #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: SPLAT-1790: allow additional tags to be specified in a failure domain #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577313e
allow additional tags to be defined in infrastructure failure domains
rvanderp3 Sep 11, 2024
e5ffa80
generated
rvanderp3 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,13 @@ type VSpherePlatformFailureDomainSpec struct {
// + Validation is applied via a patch, we validate the format as either ipv4, ipv6 or hostname
Server string `json:"server"`

// tagIDs is an optional set of tags to add to an instance. Specified tagIDs
// must use URN-notation instead of display names. A maximum of 10 tag IDs may be specified.
// +listType=set
// +kubebuilder:example=urn:vmomi:InventoryServiceTag:5736bf56-49f5-4667-b38c-b97e09dc9578:GLOBAL
// +optional
TagIDs []string `json:"tagIDs,omitempty"`

// Topology describes a given failure domain using vSphere constructs
// +kubebuilder:validation:Required
Topology VSpherePlatformTopology `json:"topology"`
Expand Down
9 changes: 9 additions & 0 deletions ...nerated.crd-manifests/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...ted.crd-manifests/0000_10_config-operator_01_infrastructures-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...ed.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
5 changes: 5 additions & 0 deletions config/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions ...generated.featuregated-crd-manifests/infrastructures.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...featuregated-crd-manifests/infrastructures.config.openshift.io/BareMetalLoadBalancer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...d.featuregated-crd-manifests/infrastructures.config.openshift.io/GCPClusterHostedDNS.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...nerated.featuregated-crd-manifests/infrastructures.config.openshift.io/GCPLabelsTags.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...ated-crd-manifests/infrastructures.config.openshift.io/VSphereControlPlaneMachineSet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ....featuregated-crd-manifests/infrastructures.config.openshift.io/VSphereMultiNetworks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ....featuregated-crd-manifests/infrastructures.config.openshift.io/VSphereMultiVCenters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags to add
to an instance. Specified tagIDs must use URN-notation
instead of display names. A maximum of 10 tag IDs
may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure domain
using vSphere constructs
Expand Down
1 change: 1 addition & 0 deletions config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions ...erated.crd-manifests/0000_80_machine-config_01_controllerconfigs-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...ed.crd-manifests/0000_80_machine-config_01_controllerconfigs-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...d.crd-manifests/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...egated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...-manifests/controllerconfigs.machineconfiguration.openshift.io/BareMetalLoadBalancer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...rd-manifests/controllerconfigs.machineconfiguration.openshift.io/GCPClusterHostedDNS.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
9 changes: 9 additions & 0 deletions ...ated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/GCPLabelsTags.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,15 @@ spec:
maxLength: 255
minLength: 1
type: string
tagIDs:
description: tagIDs is an optional set of tags
to add to an instance. Specified tagIDs must
use URN-notation instead of display names.
A maximum of 10 tag IDs may be specified.
items:
type: string
type: array
x-kubernetes-list-type: set
topology:
description: Topology describes a given failure
domain using vSphere constructs
Expand Down
Loading