Skip to content

Feature gate analyzer should look at current_runs > 0 #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Feature gate analyzer should look at current_runs > 0 #2170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/codegen/cmd/featuregate-test-analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ func testResultByName(results []TestResults, testName string) *TestResults {
}

func listTestResultFor(featureGate string, clusterProfiles sets.Set[string]) (map[JobVariant]*TestingResults, error) {
fmt.Printf("Query component readiness for all test run results for feature gate %q on clusterProfile %q\n", featureGate, sets.List(clusterProfiles))
fmt.Printf("Query sippy for all test run results for feature gate %q on clusterProfile %q\n", featureGate, sets.List(clusterProfiles))

results := map[JobVariant]*TestingResults{}

Expand Down Expand Up @@ -555,7 +555,7 @@ func listTestResultForVariant(featureGate string, jobVariant JobVariant) (*Testi
testPattern = fmt.Sprintf("install should succeed")
}

fmt.Printf("Query component readiness for all test run results for pattern %q on variant %#v\n", testPattern, jobVariant)
fmt.Printf("Query sippy for all test run results for pattern %q on variant %#v\n", testPattern, jobVariant)

defaultTransport := &http.Transport{
Proxy: http.ProxyFromEnvironment,
Expand Down
6 changes: 6 additions & 0 deletions tools/codegen/pkg/sippy/json_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ func QueriesFor(cloud, architecture, topology, networkStack, testPattern string)
queries := []*SippyQueryStruct{
{
Items: []SippyQueryItem{
{
ColumnField: "current_runs",
Not: false,
OperatorValue: ">",
Value: "0",
},
{
ColumnField: "variants",
Not: false,
Expand Down