Migrate away from deprecated ioutil

[sebrandon1]

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Migration from ioutil to os for file operations:

• Replaced ioutil.ReadFile with os.ReadFile and ioutil.WriteFile with os.WriteFile across multiple files, including config/v1/types_infrastructure_test.go, payload-command/render/renderassets/assets.go, tools/codegen/pkg/swaggerdocs/generator.go, and tools/codegen/pkg/swaggerdocs/swaggerdocs.go. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Walkthrough

Replace deprecated ioutil.ReadFile and ioutil.WriteFile calls with their os package equivalents across four Go files. Update imports accordingly while preserving all error handling and file I/O behavior.

Changes

Cohort / File(s)	Summary
ioutil → os migration config/v1/types_infrastructure_test.go, payload-command/render/renderassets/assets.go, tools/codegen/pkg/swaggerdocs/generator.go, tools/codegen/pkg/swaggerdocs/swaggerdocs.go	Replace deprecated ioutil.ReadFile and ioutil.WriteFile with os.ReadFile and os.WriteFile. Update imports from "io/ioutil" to "os". No behavioral changes to error handling or file I/O logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Homogeneous refactoring pattern applied consistently across all files
• Direct API replacement with no logic modifications
• No control flow or error handling changes
• Standard library modernization with well-established equivalents

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 999c45c and 57d5184.

📒 Files selected for processing (4)

• config/v1/types_infrastructure_test.go (2 hunks)
• payload-command/render/renderassets/assets.go (2 hunks)
• tools/codegen/pkg/swaggerdocs/generator.go (2 hunks)
• tools/codegen/pkg/swaggerdocs/swaggerdocs.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• tools/codegen/pkg/swaggerdocs/generator.go
• payload-command/render/renderassets/assets.go
• config/v1/types_infrastructure_test.go
• tools/codegen/pkg/swaggerdocs/swaggerdocs.go

🔇 Additional comments (4)

tools/codegen/pkg/swaggerdocs/generator.go (1)

5-5: LGTM: Correct migration from deprecated ioutil.

The replacement of ioutil.WriteFile with os.WriteFile is correct. Both functions have identical signatures and behavior, and this change removes usage of the deprecated ioutil package.

Also applies to: 129-129

tools/codegen/pkg/swaggerdocs/swaggerdocs.go (1)

8-8: LGTM: Correct migration from deprecated ioutil.

The replacement of ioutil.ReadFile with os.ReadFile is correct. Both functions have identical signatures and behavior, and this change removes usage of the deprecated ioutil package.

Also applies to: 68-68

config/v1/types_infrastructure_test.go (1)

4-4: LGTM: Correct migration from deprecated ioutil.

The replacement of ioutil.ReadFile with os.ReadFile is correct. Both functions have identical signatures and behavior, and this change removes usage of the deprecated ioutil package.

Also applies to: 27-27

payload-command/render/renderassets/assets.go (1)

99-99: LGTM: Correct migration from deprecated ioutil.

The replacements of ioutil.WriteFile (line 99) and ioutil.ReadFile (line 226) with their os package equivalents are correct. Both functions have identical signatures and behavior, and these changes remove usage of the deprecated ioutil package.

Also applies to: 226-226

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hello @sebrandon1! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	57d5184	link	true	/test e2e-upgrade
ci/prow/e2e-aws-ovn	57d5184	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.