Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.3] Bug 1781178: Add missing optional tags #539

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions apps/v1/types.go
Expand Up @@ -32,6 +32,7 @@ type DeploymentConfig struct {
Spec DeploymentConfigSpec `json:"spec" protobuf:"bytes,2,opt,name=spec"`

// Status represents the current deployment state.
// +optional
Status DeploymentConfigStatus `json:"status,omitempty" protobuf:"bytes,3,opt,name=status"`
}

Expand Down
6 changes: 5 additions & 1 deletion authorization/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion authorization/v1/types.go
Expand Up @@ -89,11 +89,13 @@ type RoleBinding struct {
// This field should only be specified when supporting legacy clients and servers.
// See Subjects for further details.
// +k8s:conversion-gen=false
// +optional
UserNames OptionalNames `json:"userNames" protobuf:"bytes,2,rep,name=userNames"`
// GroupNames holds all the groups directly bound to the role.
// This field should only be specified when supporting legacy clients and servers.
// See Subjects for further details.
// +k8s:conversion-gen=false
// +optional
GroupNames OptionalNames `json:"groupNames" protobuf:"bytes,3,rep,name=groupNames"`
// Subjects hold object references to authorize with this rule.
// This field is ignored if UserNames or GroupNames are specified to support legacy clients and servers.
Expand Down Expand Up @@ -322,7 +324,7 @@ type Action struct {
ResourceName string `json:"resourceName" protobuf:"bytes,6,opt,name=resourceName"`
// Path is the path of a non resource URL
Path string `json:"path" protobuf:"bytes,8,opt,name=path"`
// IsNonResourceURL is true if this is a request for a non-resource URL (outside of the resource hieraarchy)
// IsNonResourceURL is true if this is a request for a non-resource URL (outside of the resource hierarchy)
IsNonResourceURL bool `json:"isNonResourceURL" protobuf:"varint,9,opt,name=isNonResourceURL"`
// Content is the actual content of the request for create and update
// +kubebuilder:pruning:PreserveUnknownFields
Expand Down Expand Up @@ -384,11 +386,13 @@ type ClusterRoleBinding struct {
// This field should only be specified when supporting legacy clients and servers.
// See Subjects for further details.
// +k8s:conversion-gen=false
// +optional
UserNames OptionalNames `json:"userNames" protobuf:"bytes,2,rep,name=userNames"`
// GroupNames holds all the groups directly bound to the role.
// This field should only be specified when supporting legacy clients and servers.
// See Subjects for further details.
// +k8s:conversion-gen=false
// +optional
GroupNames OptionalNames `json:"groupNames" protobuf:"bytes,3,rep,name=groupNames"`
// Subjects hold object references to authorize with this rule.
// This field is ignored if UserNames or GroupNames are specified to support legacy clients and servers.
Expand Down
2 changes: 1 addition & 1 deletion authorization/v1/zz_generated.swagger_doc_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions build/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions build/v1/types.go
Expand Up @@ -23,6 +23,7 @@ type Build struct {
Spec BuildSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`

// status is the current status of the build.
// +optional
Status BuildStatus `json:"status,omitempty" protobuf:"bytes,3,opt,name=status"`
}

Expand Down Expand Up @@ -83,6 +84,7 @@ type CommonSpec struct {
// If nil, it can be overridden by default build nodeselector values for the cluster.
// If set to an empty map or a map with any values, default build nodeselector values
// are ignored.
// +optional
NodeSelector OptionalNodeSelector `json:"nodeSelector" protobuf:"bytes,9,name=nodeSelector"`
}

Expand Down Expand Up @@ -880,6 +882,7 @@ type BuildConfig struct {
// to trigger them.
Spec BuildConfigSpec `json:"spec" protobuf:"bytes,2,opt,name=spec"`
// status holds any relevant information about a build config
// +optional
Status BuildConfigStatus `json:"status" protobuf:"bytes,3,opt,name=status"`
}

Expand Down
3 changes: 3 additions & 0 deletions route/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions route/v1/types.go
Expand Up @@ -33,6 +33,7 @@ type Route struct {
// spec is the desired state of the route
Spec RouteSpec `json:"spec" protobuf:"bytes,2,opt,name=spec"`
// status is the current state of the route
// +optional
Status RouteStatus `json:"status" protobuf:"bytes,3,opt,name=status"`
}

Expand Down Expand Up @@ -67,6 +68,7 @@ type RouteSpec struct {
// If not specified a route name will typically be automatically
// chosen.
// Must follow DNS952 subdomain conventions.
// +optional
Host string `json:"host" protobuf:"bytes,1,opt,name=host"`
// subdomain is a DNS subdomain that is requested within the ingress controller's
// domain (as a subdomain). If host is set this field is ignored. An ingress
Expand Down Expand Up @@ -121,6 +123,7 @@ type RouteTargetReference struct {

// weight as an integer between 0 and 256, default 100, that specifies the target's relative weight
// against other target reference objects. 0 suppresses requests to this backend.
// +optional
Weight *int32 `json:"weight" protobuf:"varint,3,opt,name=weight"`
}

Expand Down
2 changes: 2 additions & 0 deletions template/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions template/v1/types.go
Expand Up @@ -111,6 +111,7 @@ type TemplateInstance struct {
Spec TemplateInstanceSpec `json:"spec" protobuf:"bytes,2,opt,name=spec"`

// status describes the current state of this TemplateInstance.
// +optional
Status TemplateInstanceStatus `json:"status" protobuf:"bytes,3,opt,name=status"`
}

Expand All @@ -125,6 +126,7 @@ type TemplateInstanceSpec struct {

// requester holds the identity of the agent requesting the template
// instantiation.
// +optional
Requester *TemplateInstanceRequester `json:"requester" protobuf:"bytes,3,opt,name=requester"`
}

Expand Down