Make {image,project}/v1 status fields optional #543
Conversation
openshift-ci-robot
added
size/XS
| @@ -185,8 +185,10 @@ type ImageStream struct { | |||
| metav1.ObjectMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"` | |||
|
|
|||
| // Spec describes the desired state of this stream | |||
| // +optional | |||
There was a problem hiding this comment.
this one only has optional fields and it's natural to have it without spec.
sttts
force-pushed
the
sttts-image-optional-markers
branch
from
83c6863
to
34cf3fb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.3 |
|
@soltysh: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@soltysh: new pull request created: #544 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.