Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-13946: Ignore Proliant Gen 11 serial #522

Merged
merged 1 commit into from Mar 19, 2023

Conversation

avishayt
Copy link
Contributor

We have seen different hosts with the same motherboard serial on this type of hardware, so we should ignore it and fallback to other methods of generating the host UUID.

We have seen different hosts with the same motherboard serial on this
type of hardware, so we should ignore it and fallback to other methods
of generating the host UUID.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023

@avishayt: This pull request references MGMT-13946 which is a valid jira issue.

In response to this:

We have seen different hosts with the same motherboard serial on this type of hardware, so we should ignore it and fallback to other methods of generating the host UUID.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2023
@openshift-ci openshift-ci bot requested review from flaper87 and gamli75 March 15, 2023 14:03
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #522 (7ecb73e) into master (6e1718d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   60.44%   60.44%           
=======================================
  Files          70       70           
  Lines        3484     3484           
=======================================
  Hits         2106     2106           
  Misses       1228     1228           
  Partials      150      150           
Impacted Files Coverage Δ
src/scanners/machine_uuid_scanner.go 67.74% <ø> (ø)

@tsorya
Copy link
Contributor

tsorya commented Mar 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6e1718d and 2 for PR HEAD 7ecb73e in total

@avishayt
Copy link
Contributor Author

/override ci/prow/e2e-agent-compact

@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2023

@avishayt: Overrode contexts on behalf of avishayt: ci/prow/e2e-agent-compact

In response to this:

/override ci/prow/e2e-agent-compact

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avishayt
Copy link
Contributor Author

/test edge-e2e-metal-assisted

@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2023

@avishayt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d59f034 into openshift:master Mar 19, 2023
10 checks passed
@avishayt
Copy link
Contributor Author

/cherry-pick release release-4.13

@openshift-cherrypick-robot

@avishayt: cannot checkout release release-4.13: error checking out release release-4.13: exit status 1. output: error: pathspec 'release release-4.13' did not match any file(s) known to git

In response to this:

/cherry-pick release release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avishayt
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@avishayt: new pull request created: #523

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avishayt
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@avishayt: new pull request created: #524

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
We have seen different hosts with the same motherboard serial on this
type of hardware, so we should ignore it and fallback to other methods
of generating the host UUID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants