Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update approvers and reviewers lists #550

Merged
merged 1 commit into from Sep 20, 2022

Conversation

osherdp
Copy link
Member

@osherdp osherdp commented Sep 20, 2022

What

This change updates the lists and makes some cleanups and refactorings to the way we're handling those lists of approvers/reviewers.

Why

Changing the appropriate lists have the potential to improve the following aspects:

  • Prow uses those lists to automatically mention (/auto-cc) several point-of-contacts. It should consider availability of the member, but it does ignore members' that are more active in a repo. It means some members might get a little more noise in their emails / github notifications while other more relevant members might miss some important notification for the relevant changes.
  • PR authors (especially newcomers) will have it easy to understand who they should reach for the review / testing processes.

How

I mostly used git shortlog -s -n --no-merges --since "2022-01-01" to understand who are the recent contributers for the repo and also team's association. (e.g. members that are part of the nvidia-GPU team)

FAQ

Q: If I'm out of 'reviewers' list. Does it mean I won't be able to
/lgtm?
A: Not for all I know. Everyone in the openshift organization should
be able to /lgtm. This list is for choosing good candidates for
lgtm-ing while it automatically chooses reviewers. Read more about it
here: https://www.kubernetes.dev/docs/guide/owners/#owners

Q: I'm an approver and I need to stay an approver. A: No problem. Reach out either in this PR or privately and I'll gladly
make the adjustments.

Q: What the emeritus_approvers means?
A: It's mainly a documentation title for all I know, that doesn't grant
the ability to do /approve. It's a good way to annotate some
member as previous approver, that can return being an approver in the
future as needed. So it's a good way to transition ownership. Read
more about it here:
https://www.kubernetes.dev/docs/guide/owners/#emeritus

/cc empovit celebdor yevgeny-shnaidman lranjbar jakub-dzon pkliczewski masayag jordigilh machacekondra sagidayan
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2022
What
----

This change updates the lists and makes some cleanups and refactorings
to the way we're handling those lists of approvers/reviewers.

Why
---

Changing the appropriate lists have the potential to improve the
following aspects:
- Prow uses those lists to automatically mention (``/auto-cc``) several
  point-of-contacts. It should consider availability of the member, but
  it does ignore members' that are more active in a repo. It means some
  members might get a little more noise in their emails / github
  notifications while other more relevant members might miss some
  important notification for the relevant changes.
- PR authors (especially newcomers) will have it easy to understand who
  they should reach for the review / testing processes.

How
---

I mostly used ``git shortlog -s -n --no-merges --since "2022-01-01"`` to
understand who are the recent contributers for the repo and also team's
association. (e.g. members that are part of the nvidia-GPU team)

FAQ
---

Q: If I'm out of 'reviewers' list. Does it mean I won't be able to
   ``/lgtm``?
A: Not for all I know. Everyone in the ``openshift`` organization should
   be able to ``/lgtm``. This list is for choosing good candidates for
   lgtm-ing while it automatically chooses reviewers. Read more about it
   here: https://www.kubernetes.dev/docs/guide/owners/#owners

Q: I'm an approver and I need to stay an approver.
A: No problem. Reach out either in this PR or privately and I'll gladly
   make the adjustments.

Q: What the ``emeritus_approvers`` means?
A: It's mainly a documentation title for all I know, that doesn't grant
   the ability to do ``/approve``. It's a good way to annotate some
   member as previous approver, that can return being an approver in the
   future as needed. So it's a good way to transition ownership. Read
   more about it here:
   https://www.kubernetes.dev/docs/guide/owners/#emeritus
@osherdp
Copy link
Member Author

osherdp commented Sep 20, 2022

/cc ybettan

@openshift-ci openshift-ci bot requested a review from ybettan September 20, 2022 19:03
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Member Author

osherdp commented Sep 20, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1264be8 into openshift:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants