Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-11813: how to install HASC doc #4663

Merged
merged 1 commit into from Nov 27, 2022
Merged

MGMT-11813: how to install HASC doc #4663

merged 1 commit into from Nov 27, 2022

Conversation

slaviered
Copy link
Contributor

@slaviered slaviered commented Nov 23, 2022 •
edited

Add user facing documnetation on how to install hypershift and HASC CR

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2022
@slaviered slaviered marked this pull request as ready for review November 23, 2022 08:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@slaviered
Copy link
Contributor Author

/assign @danielerez

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slaviered

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
danielerez
danielerez reviewed Nov 23, 2022
View reviewed changes
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
@slaviered slaviered changed the title MGMT-11813: how to install HASC doc MGMT-11813: WIP: how to install HASC doc Nov 23, 2022
@slaviered slaviered changed the title MGMT-11813: WIP: how to install HASC doc MGMT-11813: how to install HASC doc Nov 27, 2022
danielerez
danielerez reviewed Nov 27, 2022
View reviewed changes
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md
```bash
# install OLM (change versions as they progress)
# download the installation script
https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.22.0/install.sh -o install.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this?

docs/user-guide/hypershift-agent-service-config.md Outdated
./install.sh v0.22.0

# install assisted infrastructure operator
oc create namespace $CLUSTERNAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this?

docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
docs/user-guide/hypershift-agent-service-config.md Outdated Show resolved Hide resolved
@slaviered
MGMT-11813: how to install HASC doc
729fd25 
Add user facing documnetation on how to install hypershift and
HASC CR
@danielerez
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2022

@slaviered: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a328edf into openshift:master Nov 27, 2022
@slaviered slaviered deleted the hasc-usage-doc branch February 2, 2023 10:58
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@slaviered @danielerez
MGMT-11813: how to install HASC doc (openshift#4663)
fc52fd0 
Add user facing documnetation on how to install hypershift and
HASC CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielerez danielerez danielerez left review comments

@omertuc omertuc Awaiting requested review from omertuc

@romfreiman romfreiman Awaiting requested review from romfreiman

Assignees

@danielerez danielerez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slaviered @danielerez @openshift-merge-robot