MGMT-13081: CI to use CentOS8 #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
openshift-ci
bot
added
the
size/XS
|
@nmagnezi: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/test edge-lint |
osherdp
approved these changes
Dec 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 67.77% 67.78% +0.01%
==========================================
Files 202 202
Lines 30087 30077 -10
==========================================
- Hits 20390 20387 -3
+ Misses 7889 7882 -7
Partials 1808 1808
|
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
5d8a532
to
420ac8b
Compare
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
420ac8b
to
95c4b65
Compare
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
95c4b65
to
bc1a1de
Compare
|
/test edge-unit-test |
|
/test edge-subsystem-aws |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
bc1a1de
to
689f84e
Compare
|
/test edge-unit-test |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
689f84e
to
cb6ed3f
Compare
|
/test edge-unit-test |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
cb6ed3f
to
9d80678
Compare
openshift-ci
bot
added
size/M
|
/test edge-unit-test |
1 similar comment
|
/test edge-unit-test |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
0e78697
to
ed57d4f
Compare
|
/test edge-unit-test |
|
/test edge-unit-test |
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
ed57d4f
to
c090d66
Compare
|
/test edge-unit-test |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
3 times, most recently
from
bc1ac69
to
40934d9
Compare
|
/test mce-images |
1 similar comment
|
/test mce-images |
osherdp
suggested changes
Jan 5, 2023
filanov
reviewed
Jan 5, 2023
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
40934d9
to
aa7fa92
Compare
assisted service is expected to build and run on CentOS8 / RHEL8. This PR is aligning CI to use that instead of CentOS9. Additionally, some unit tests were fixed to be less flaky when working with slower databases. Some tests were besing on object ordering which was never ensured and failed those tests from time to time.
nmagnezi
force-pushed
the
MGMT-13081_CI_Use_CentOS8
branch
from
aa7fa92
to
acd7e3f
Compare
osherdp
approved these changes
Jan 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmagnezi, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20 tasks
|
@nmagnezi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
eliorerz
pushed a commit
to eliorerz/assisted-service
that referenced
this pull request
Jan 29, 2023
assisted service is expected to build and run on CentOS8 / RHEL8. This PR is aligning CI to use that instead of CentOS9. Additionally, some unit tests were fixed to be less flaky when working with slower databases. Some tests were besing on object ordering which was never ensured and failed those tests from time to time.
danielerez
pushed a commit
to danielerez/assisted-service
that referenced
this pull request
Oct 15, 2023
assisted service is expected to build and run on CentOS8 / RHEL8. This PR is aligning CI to use that instead of CentOS9. Additionally, some unit tests were fixed to be less flaky when working with slower databases. Some tests were besing on object ordering which was never ensured and failed those tests from time to time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assisted service is expected to build and run on CentOS8 / RHEL8.
This PR is aligning CI to use that instead of CentOS9.
/cc @osherdp
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist