OCPBUGS-3990: Add HyperShift specific priorityClass #167
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@jsafrane: This pull request references Jira Issue OCPBUGS-3990, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pkg/operator/starter.go
Outdated
| return nil | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
IMO the withHypershiftDeploymentHook function would be a better place for this, what do you think?
There was a problem hiding this comment.
Agreed.
Initialy, I saw a separate withHypershiftReplicasHook, so it looks like the idea was to have fine-grained hooks. But it looks weird to have them that fine grained.
jsafrane
force-pushed
the
hypershift-priorityclass
branch
from
8421b8e
to
3e1b978
Compare
pkg/operator/starter.go
Outdated
| @@ -169,6 +171,7 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller | |||
| controlPlaneInformersForEvents, | |||
| withHypershiftDeploymentHook(isHypershift, os.Getenv(hypershiftImageEnvName)), | |||
| withHypershiftReplicasHook(isHypershift, guestNodeInformer.Lister()), | |||
| withHypershiftPriorityClass(isHypershift), | |||
There was a problem hiding this comment.
You forgot to remove this line
HyperShift needs guest cluster control plane components with priority "hypershift-control-plane", https://hypershift-docs.netlify.app/how-to/distribute-hosted-cluster-workloads/
jsafrane
force-pushed
the
hypershift-priorityclass
branch
from
3e1b978
to
6ad82ea
Compare
|
@jsafrane: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-3990 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@jsafrane: new pull request created: #170 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
HyperShift needs guest cluster control plane components with priority
"hypershift-control-plane", https://hypershift-docs.netlify.app/how-to/distribute-hosted-cluster-workloads/@openshift/storage