Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1942883: Rebase to v0.10.1 #183

Merged
merged 120 commits into from Apr 14, 2021

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Apr 13, 2021

Diff to upstream v0.10.1:
kubernetes-sigs/aws-ebs-csi-driver@v0.10.1...jsafrane:rebase-0.10.1
Changes in golang.org/x/crypto are expected - we use newer version to fix https://bugzilla.redhat.com/show_bug.cgi?id=1910238

It should fix following BZs:
https://bugzilla.redhat.com/show_bug.cgi?id=1932133
https://bugzilla.redhat.com/show_bug.cgi?id=1942883
https://bugzilla.redhat.com/show_bug.cgi?id=1932135
(and many more upstream issues)

cc @openshift/storage

Ayberk Yilmaz and others added 30 commits February 3, 2021 15:58
Most application charts don't usually create `StorageClass`es. They create PVCs.
feat: Add option to provision StorageClasses
Apply nodeSelector, affinity, tolerations and priorityClassName to snapshoter.
Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
…elector

More controll over snapshot-controller scheduling
…test

Integrate external e2e test in the testsuits
…-error-code

modify error message when request volume is in use with other node
Add support for node existing service accounts
…n-storage-classes

Allow all fields to be set on StorageClasses
CSI controller and node have different needs in a manner of capacity so
in this commit we enable users to define specific resources for the node
component. This will allow users not to reserve not needed resources on
all of their instances as node is a DaemonSet and may not need as much
CPU/Memory as the controller Pods.

Signed-off-by: dntosas <ntosas@gmail.com>
CSI components and especially the node one, may be critical for
operators so in this commit we enable them to define priorities for this
kind of Pods.

Signed-off-by: dntosas <ntosas@gmail.com>
…verride-for-node

[chart] Allow resources override for node DaemonSet + priorityClassName
tomdymond and others added 7 commits March 29, 2021 11:45
Example of a possible env var would be: AWS_STS_REGIONAL_ENDPOINTS=regiojnal
Update chart values with controller envVars
Warn users about migrating nodes without fully draining them of mounted
EBS volumes.

Signed-off-by: Matt Wilder <me@partcyb.org>
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 13, 2021
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1942883, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1942883: Rebase to v0.10.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 13, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1942883, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1942883: Rebase to v0.10.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 13, 2021
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1942883, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 13, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 13, 2021
@jsafrane
Copy link
Author

I fixed the OWNERS

@jsafrane
Copy link
Author

/retest
TLS errors

@huffmanca
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9f2cc4e into openshift:master Apr 14, 2021
@openshift-ci-robot
Copy link

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 1942883 has been moved to the MODIFIED state.

In response to this:

Bug 1942883: Rebase to v0.10.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet