Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1955474: Rebase v1.0.0 #185

Merged
merged 70 commits into from May 4, 2021
Merged

Bug 1955474: Rebase v1.0.0 #185

merged 70 commits into from May 4, 2021

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Apr 30, 2021 •
edited

kubernetes-sigs/aws-ebs-csi-driver@v1.0.0...bertinatto:rebase-v1.0

CC @openshift/storage

/hold
Just checking CI for now.

AndyXiangLi and others added 30 commits March 23, 2021 14:29
@AndyXiangLi
release v0.9.1
32ba8da
@AndyXiangLi
track driver start time in the e2e test
bdf5075
@k8s-ci-robot
Merge pull request kubernetes-sigs#815 from AndyXiangLi/track-start-time
cdbec43 
Track driver deploy time in e2e test pipeline
@k8s-ci-robot
Merge pull request kubernetes-sigs#813 from vdhanan/master
0ab2b50 
release v0.9.1
@jsafrane
Cap IOPS when calculating from iopsPerGB
a030826 
Consider AWS IOPS limits when calculating IOPS from iopsPerGB to always
provision a supported volume.
@jsafrane
Add logs for increasing / capping IOPS
39ec1f7
@jsafrane
Update README with iops capping
d5b4c05
@jsafrane
Add increaseTooLowIOPS parameter
0ecc0e9
@tomdymond
Add the possibility of passing additional env vars
0fdab20 
Example of a possible env var would be: AWS_STS_REGIONAL_ENDPOINTS=regiojnal
@tomdymond
Additonal environment variables for the controller
a81d1d8 
Update chart values with controller envVars
@tomdymond
Update patch version
5924f16
@k8s-ci-robot
Merge pull request kubernetes-sigs#817 from tomdymond/tomdymond-patch…
8ffc74d 
…-1-controller-vars

AWS EBS CSI Driver Helm chart to inject environment variables
@vdhanan
release v0.10.0
9bfd1c5
@k8s-ci-robot
Merge pull request kubernetes-sigs#820 from vdhanan/master
a5882e3 
release v0.10.0
@partcyborg
Warn users of migrating without draining
4520ce3 
Warn users about migrating nodes without fully draining them of mounted
EBS volumes.

Signed-off-by: Matt Wilder <me@partcyb.org>
@k8s-ci-robot
Merge pull request kubernetes-sigs#822 from partcyborg/master
aab411e 
Warn users of migrating without draining
@AndyXiangLi
support volume partition
9bcdfd3
@AndyXiangLi
Merge pull request kubernetes-sigs#824 from AndyXiangLi/volume-partition
21e5b06 
support volume partition
@AndyXiangLi
release v0.10.1
0973a6b
@AndyXiangLi
Merge pull request kubernetes-sigs#827 from AndyXiangLi/master
581ecc6 
release v0.10.1
@k8s-ci-robot
Merge pull request kubernetes-sigs#809 from jsafrane/cap-iops
9f4ce44 
Cap IOPS when calculating from iopsPerGB
@wongma7 @jsafrane
Bump k8s dependencies to 1.20.4, csi spec to 1.3, external-snapshotte…
410b6c7 
…r client to v4, go to 1.16
@wongma7 @jsafrane
Use v4 snapshotter client and assume v1 CRDs in e2e tests
ced8a2a
@wongma7 @jsafrane
Update to new k8s client API with contexts and options
a278dd8
@wongma7 @jsafrane
Leave ControllerGetVolume unimplemented
6915bde
@wongma7 @jsafrane
Run go mod tidy && go mod vendor
5d42c85
@wongma7 @jsafrane
Rename statefulset.yaml to snapshot-controller.yaml
38fba27
@wongma7 @jsafrane
Update snapshot API CRDs to v1
abf36d9
@wongma7 @jsafrane
Fix empty default tolerations in snapshot controller
b939896
@wongma7 @jsafrane
Run make generate-kustomize
6c6a3c9
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@bertinatto bertinatto changed the title Rebase v1.0 Bug 1955474: Rebase v1.0.0 Apr 30, 2021
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Bugzilla bug 1955474, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

In response to this:

Bug 1955474: Rebase v1.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 30, 2021
@jsafrane
Copy link

jsafrane commented May 4, 2021

/test e2e-aws-csi
2nd run just to be sure

@bertinatto
Copy link
Member Author

/hold cancel
PR is ready to be merged, assuming CI is green.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@bertinatto
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 4, 2021
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Bugzilla bug 1955474, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link

jsafrane commented May 4, 2021

/lgtm
This will be re-tested number of times because of our faulty snapshot tests. Please watch for any other failed tests.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e4e770a into openshift:master May 4, 2021
@openshift-ci-robot
Copy link

@bertinatto: All pull requests linked via external trackers have merged:

Bugzilla bug 1955474 has been moved to the MODIFIED state.

In response to this:

Bug 1955474: Rebase v1.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huffmanca huffmanca Awaiting requested review from huffmanca

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet