Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase v1.5.1 #195

Merged
merged 97 commits into from Feb 3, 2022
Merged

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Feb 2, 2022

wongma7 and others added 30 commits July 26, 2021 16:13
Update kustomize templates only after verifying images are available in registries
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
…trategy

[chart] Node update strategy & auto driver image tag
Build and push multi-arch/os (amazon and windows, no debian) image manifest via Make rules
Fix github build failing because of wrong docker hub registry name
Fix gcr prow build failing because of IMAGE variable collision
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Update helm chart alongside kustomize, after images have been pushed, for consistency
…ler-strategy

[chart] Add controller strategy
Fix gcr prow builld failing because docker missing --os-version
Include ClusterRole and ClusterRoleBinding for csi-node
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@bertinatto bertinatto changed the title WIP: Rebase v1.5.1 Rebase v1.5.1 Feb 2, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
@bertinatto
Copy link
Member Author

/hold
Until the team agrees whether this is a good idea.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Feb 2, 2022

/lgtm
I think we want this in master anyway, but leaving the hold until we discuss with the rest of the team.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@jsafrane
Copy link

jsafrane commented Feb 3, 2022

/hold cancel

+1, we want it in master anyway.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit bdf3491 into openshift:master Feb 3, 2022
@bertinatto
Copy link
Member Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@bertinatto: new pull request created: #196

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet