Bug 2050173: Fix build on ARM after rebase #198
Conversation
The Makefile now defines ARCH?=amd64 which is used to define GOARCH, which breaks the builds on other arches (namely arm64, given this is for AWS).
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@yselkowitz: This pull request references Bugzilla bug 2050173, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/test all |
|
@yselkowitz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @jsafrane |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
|
/cherry-pick release-4.10 |
|
@yselkowitz: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yselkowitz: All pull requests linked via external trackers have merged: Bugzilla bug 2050173 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yselkowitz: new pull request created: #199 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a bug fix or adding new feature?
/type bug
What is this PR about? / Why do we need it?
The Makefile now defines ARCH?=amd64 which is used to define GOARCH,
which breaks the builds on other arches (namely arm64, given this is for
AWS).
Without this, 4.10 and 4.11 CI on AWS turned solid red.