Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2050190: Fix build on ARM after rebase #199

Merged
merged 1 commit into from Feb 7, 2022
Merged

[release-4.10] Bug 2050190: Fix build on ARM after rebase #199

merged 1 commit into from Feb 7, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #198

/assign yselkowitz

@yselkowitz
Fix build on ARM after rebase
f5fa465 
The Makefile now defines ARCH?=amd64 which is used to define GOARCH,
which breaks the builds on other arches (namely arm64, given this is for
AWS).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 7, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 2050173 with correct target release. Retitling PR to link to clone:
/retitle [release-4.10] Bug 2050190: Fix build on ARM after rebase

In response to this:

[release-4.10] Bug 2050173: Fix build on ARM after rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2050173: Fix build on ARM after rebase [release-4.10] Bug 2050190: Fix build on ARM after rebase Feb 7, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2050190, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2050173 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2050173 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

In response to this:

[release-4.10] Bug 2050190: Fix build on ARM after rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 7, 2022
@yselkowitz
Copy link

/assign @bertinatto

@deads2k deads2k added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Feb 7, 2022
bertinatto
bertinatto reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8ba0c7a into openshift:release-4.10 Feb 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2050190 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2050190: Fix build on ARM after rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member

dobsonj commented Jul 19, 2022

/cherry-pick release-4.9
see https://bugzilla.redhat.com/show_bug.cgi?id=2103982

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 19, 2022
Merged
@openshift-cherrypick-robot
Copy link
Author

@dobsonj: new pull request created: #204

In response to this:

/cherry-pick release-4.9
see https://bugzilla.redhat.com/show_bug.cgi?id=2103982

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@Phaow Phaow Awaiting requested review from Phaow

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

@yselkowitz yselkowitz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @yselkowitz @dobsonj @bertinatto @deads2k @openshift-merge-robot