Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2106910: Rebase to v1.4.0 #205

Merged
merged 182 commits into from Jul 26, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jul 22, 2022

https://bugzilla.redhat.com/show_bug.cgi?id=2106910
kubernetes-sigs/aws-ebs-csi-driver@v1.4.0...dobsonj:bug2106910-rebase
Note: this PR includes the rebase + the fix for the ARM build issue from #204
/cc @openshift/storage
/hold for testing

wongma7 and others added 30 commits May 26, 2021 17:05
merge v1.1.0 release commits back to master
…-idempotent

update inFlight cache to avoid race condition on volume operation
helm chart configurable log verbosity
Add test-e2e-external-eks make rule that tests EKS with pod instance metadata disabled. Remove hostNetwork from DaemonSet
Default extra-create-metadata true so that volumes get created with pvc/pv tags
Add KubernetesCluster tag to provisioned volumes when cluster-id set
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

@dobsonj: This pull request references Bugzilla bug 2106910, which is invalid:

  • expected dependent Bugzilla bug 2103982 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2106910: Rebase to v1.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 22, 2022

go mod tidy: go.mod file indicates go 1.16, but maximum supported version is 1.15

This should be fixed by openshift/release#30743

@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

@dobsonj: This pull request references Bugzilla bug 2106910, which is invalid:

  • expected dependent Bugzilla bug 2103982 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2106910: Rebase to v1.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 25, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

@dobsonj: This pull request references Bugzilla bug 2106910, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2103982 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2103982 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 25, 2022

I verified this rebase solves the scenario from the bug report
/unhold
/label backport-risk-assessed
And the openshift/release PR merged
/retest

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@Phaow
Copy link

Phaow commented Jul 26, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 26, 2022
@openshift-merge-robot openshift-merge-robot merged commit f052c89 into openshift:release-4.8 Jul 26, 2022
5 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2022

@dobsonj: All pull requests linked via external trackers have merged:

Bugzilla bug 2106910 has been moved to the MODIFIED state.

In response to this:

Bug 2106910: Rebase to v1.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet