Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS #157

Merged
merged 1 commit into from Oct 12, 2022
Merged

Update OWNERS #157

merged 1 commit into from Oct 12, 2022

Conversation

2uasimojo
Copy link
Member

/assign @suhanime

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 6, 2022
@suhanime
Copy link

suhanime commented Oct 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@suhanime
Copy link

suhanime commented Oct 6, 2022

/verify-owners

/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@2uasimojo
Copy link
Member Author

/retest

4 similar comments
@2uasimojo
Copy link
Member Author

/retest

@2uasimojo
Copy link
Member Author

/retest

@2uasimojo
Copy link
Member Author

/retest

@2uasimojo
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member Author

Well cool. Now we need someone who's authorized to either add labels or force merge. I don't know if that's based on repo permissions or the OWNERS file; if the latter, only @abutcher can help us.

@abutcher
Copy link
Member

abutcher commented Oct 10, 2022 •
edited

I can't interact with labels on this PR or force merge.

@2uasimojo
Copy link
Member Author

@sjenning do you have the power to make this go?

@sjenning sjenning merged commit 6197630 into openshift:master Oct 12, 2022
@2uasimojo 2uasimojo deleted the update-owners-master branch October 12, 2022 14:16
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-pod-identity-webhook-container-v4.12.0-202305022015.p0.g6197630.assembly.stream for distgit ose-aws-pod-identity-webhook.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@suhanime suhanime

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@2uasimojo @suhanime @abutcher @openshift-bot @sjenning