Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2043118: Move from Available to Preparing if HostFirmwareSettings… #208

Merged
merged 1 commit into from Feb 8, 2022

Conversation

bfournie
Copy link

@bfournie bfournie commented Feb 7, 2022

… changed

Currently if the host is in the Available state and the HFS settings are
changed it doesn't transition to the Preparing state as it would when the
BareMetalHost settings are changed. This change fixes that.

(cherry picked from commit cd3340b)

… changed

Currently if the host is in the Available state and the HFS settings are
changed it doesn't transition to the Preparing state as it would when the
BareMetalHost settings are changed. This change fixes that.

(cherry picked from commit cd3340b)
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

@bfournie: This pull request references Bugzilla bug 2043118, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lshilin@redhat.com), skipping review request.

In response to this:

Bug 2043118: Move from Available to Preparing if HostFirmwareSettings…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 7, 2022
@openshift-ci openshift-ci bot requested review from honza and sadasu February 7, 2022 15:34
@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@honza
Copy link
Member

honza commented Feb 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@bfournie
Copy link
Author

bfournie commented Feb 7, 2022

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2022

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 97a0954 into openshift:master Feb 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2022

@bfournie: All pull requests linked via external trackers have merged:

Bugzilla bug 2043118 has been moved to the MODIFIED state.

In response to this:

Bug 2043118: Move from Available to Preparing if HostFirmwareSettings…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie bfournie deleted the bug2043118 branch February 8, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants