Merge upstream #211
Merge upstream #211
Conversation
The root device hints have a rotational field which is a pointer to a bool. Use DeepCopy and DeepEqual to ensure its handled properly.
This PR adds mac address validation for BootMACAddress if it is not empty.
This change reduces the resource footprint of the installation and paves the way to dropping MariaDB by default (not a part of this patch). TLS support is switched to use httpd as a reverse proxy.
Add mac address validation for BootMACAddress
If the ImageError condition is not set yet (which can happen before the PreprovisioningImage controller reconciles the resource), we will get a nil condition back from FindStatusCondition.
Make sure that the ImageReady condition value corresponds to the current generation of the resource before declaring the image ready.
The PreprovisioningImage controller may wish to use information in the host's labels to influence the image build, so copy all labels from the Host to the Image to ensure that the controller has access to them without having to retrieve the Host from the k8s API.
Use deep copy/equal for host root device hints
Copy labels from BaremetalHost to PreprovisioningImage
Switch the deployment to use a single ironic process
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@honza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.