Bug 2092650: Stop treating missing network as fatal error

[derekhiggins]

Report that NetworkData isn't available and return a
blank string id the sectret is present but doesn't contain
the expected key. This is the same as the behaviour when the
secret isn't present at all.

[openshift-ci]

@derekhiggins: This pull request references Bugzilla bug 2092650, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (adistefa@redhat.com), skipping review request.

In response to this:

Bug 2092650: Stop treating missing network as fatal error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[honza]

Do we want this upstream first?

[aleskandro]

Hello, PTAL my last comment in https://bugzilla.redhat.com/show_bug.cgi?id=2092650 before proceeding with the review and merge

[zaneb]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[derekhiggins]

Do we want this upstream first?

Sorry, I should have done that first, PR is up now
metal3-io#1135

[derekhiggins]

/test e2e-metal-ipi-serial-ipv4

[dtantsur]

/lgtm

I don't like it, but I don't have better ideas

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD a99095a and 8 for PR HEAD 2664085 in total

[openshift-ci]

@derekhiggins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@derekhiggins: All pull requests linked via external trackers have merged:

• openshift/baremetal-operator#227

Bugzilla bug 2092650 has been moved to the MODIFIED state.

In response to this:

Bug 2092650: Stop treating missing network as fatal error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derekhiggins]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@derekhiggins: new pull request created: #230

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.