[release-4.12] OCPBUGS-14188: Deleting unmanaged BMH get stuck fix #283
Conversation
Ironic doesn't do any work to speak of in the host's 'deleting' state. It appears this was added (in c3c2c88) due to confusion between ironic's 'deleting' (i.e. the 'deprovisioning' state in Metal³) and Metal³'s 'deleting' state. A result of this was that hosts in the 'unmanaged' state could not be deleted, because by definition they do not have BMC credentials, but the check for Ironic capacity required them. Since unmanaged hosts do not go through 'deprovisioning', removing this unnecessary check from the 'deleting' state should be enough to allow them to be deleted again.
This is no longer needed now that we don't wait for provisioner capacity when going from deprovisioning->deleting.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-13927 has been cloned as Jira Issue OCPBUGS-14188. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-14188, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci-robot
added
jira/valid-bug
|
@zaneb: This pull request references Jira Issue OCPBUGS-14188, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/lgtm |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-14188: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14188 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.12.0-0.nightly-2023-06-06-140730 |
This is an automated cherry-pick of #281
/assign hroyrh