Monitor - delete iptable rule if API not reachable through Haproxy #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/approve |
openshift-ci-robot
added
the
approved
celebdor
approved these changes
Aug 2, 2019
openshift-ci-robot
added
size/S
celebdor
requested changes
Aug 7, 2019
pkg/monitor/monitor.go
Outdated
| @@ -144,16 +146,21 @@ func Monitor(clusterName, clusterDomain, templatePath, cfgPath, apiVip string, a | |||
|
|
|||
| ok, err := utils.IsKubernetesHealthy(lbPort) | |||
| if err == nil && ok { | |||
| log.Info("API reachable through HAProxy") | |||
| if k8sIsHealthy == false { | |||
There was a problem hiding this comment.
Suggested change
| if k8sIsHealthy == false { | |
| if ! k8sIsHealthy { |
pkg/monitor/monitor.go
Outdated
| err := ensureHAProxyPreRoutingRule(apiVip, apiPort, lbPort) | ||
| if err != nil { | ||
| log.WithFields(logrus.Fields{"err": err}).Error("Failed to ensure HAProxy PREROUTING rule to direct traffic to the LB") | ||
| } | ||
| } else { | ||
| log.Info("API still not reachable through HAProxy") | ||
| cleanHAProxyPreRoutingRule(apiVip, apiPort, lbPort) | ||
| if k8sIsHealthy == true { |
There was a problem hiding this comment.
Suggested change
| if k8sIsHealthy == true { | |
| if k8sIsHealthy { |
openshift-ci-robot
removed
the
approved
If Haproxy went down for some reason, the Iptable rule that redirects API traffic to Haproxy LB, should be removed. This change also updates logging to report LB status only upon a change instead of reporting the current status every 15 seconds.
bcrochet
approved these changes
Aug 8, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, celebdor, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Haproxy went down for some reason, the Iptable rule that
redirects API traffic to Haproxy LB, should be removed.