New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2012780: Avoid dynamically allocated port range for haproxy #155
Bug 2012780: Avoid dynamically allocated port range for haproxy #155
Conversation
@cybertron: This pull request references Bugzilla bug 2012780, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Hmm, seems that stat port is still 50000 , [1] [2] |
The haproxy stats and health endpoints were configured with high port numbers (50000 and 50936) that conflict with the range used for dynamic allocation of ports: $ cat /proc/sys/net/ipv4/ip_local_port_range 32768 60999 This can occasionally cause haproxy to fail if the kernel happens to pick one of those ports for a client connection. To avoid this, we should use ports outside the range shown above. This patch changes the stats endpoint to 30000, while the health endpoint is controlled by the MCO config and will be fixed in a separate commit there.
b557c84
to
65cf23b
Compare
Bah. This version should catch all of the places that value is specified. |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cybertron: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2012780 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.9 |
@cybertron: new pull request created: #167 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The haproxy stats and health endpoints were configured with high
port numbers (50000 and 50936) that conflict with the range used for
dynamic allocation of ports:
$ cat /proc/sys/net/ipv4/ip_local_port_range
32768 60999
This can occasionally cause haproxy to fail if the kernel happens to
pick one of those ports for a client connection.
To avoid this, we should use ports outside the range shown above.
This patch changes the stats endpoint to 30000, while the health
endpoint is controlled by the MCO config and will be fixed in a
separate commit there.