OCPBUGS-673: Apply ipv6 bind check to non-VIP case too #192
Conversation
In openshift#181 we fixed a problem where ipv6 addresses are initially in a state that is not usable by services. However, this was only done for the code path where VIPs are in use, so it only applies to IPI deployments that are not using remote workers. It turns out this is also happening on non-IPI deployments (and likely for IPI deployments with remote workers), so we need to run the same check on that code path. (cherry picked from commit 998bbd4)
Because chosen is function-scoped, it is persistent over multiple iterations of the loop. If the first iteration fails and we retry, the second time around we skip the AddressesDefault case because chosen is no longer empty. This means the retries will never succeed. If we just re-initialize the chosen list before retrying then it should get repopulated the next time through and the retry mechanism will work as expected. (cherry picked from commit 1898207)
openshift-ci-robot
added
the
jira/valid-bug
|
@cybertron: This pull request references Jira Issue OCPBUGS-673, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@cybertron: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
@dougsland @reihl Please take a look at this backport. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, dougsland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@cybertron: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approved |
|
/label backport-risk-assessed @reihl We still need cherry-pick-approved too. |
openshift-ci
bot
added
the
backport-risk-assessed
|
/cherry-pick-approved |
@reihl, It looks like the bot didn't take that. You think you have to do |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@cybertron: Jira Issue OCPBUGS-673 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of the two patches needed to make the ipv6 bind check work on UPI platforms too.