New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manage-dockerfile: use the original form of ENV/LABEL #134
manage-dockerfile: use the original form of ENV/LABEL #134
Conversation
When rewriting the Dockerfile with our substitutions, we unconditionally insert `=` characters, even in cases where the original file didn't use them. They're syntactically important, though, so such changes can cause builds to fail. For ENV and LABEL instructions, just emit the original text. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
851c2b4
to
f5a7078
Compare
Added unit tests. |
Fixing through simplification LGTM |
/test e2e-aws-builds |
1 similar comment
/test e2e-aws-builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Would like a second for lgtm. Do we want a BZ for this so we can land it in 4.4.0?
/lgtm @gabemontero already gave it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When rewriting the Dockerfile with our substitutions, we unconditionally insert
=
characters, even in cases where the original file didn't use them. They're syntactically important, though, so such changes can cause builds to fail. For ENV and LABEL instructions, just emit the original text.Fixes openshift/origin#24151.