Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1920626: narrow scope of rhsm transient bind mount #211

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #206

/assign gabemontero

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1916897 has been cloned as Bugzilla bug 1920626. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1920626: narrow scope of rhsm transient bind mount

In response to this:

[release-4.6] Bug 1916897: narrow scope of rhsm transient bind mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1916897: narrow scope of rhsm transient bind mount [release-4.6] Bug 1920626: narrow scope of rhsm transient bind mount Jan 26, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1920626, which is invalid:

  • expected dependent Bugzilla bug 1916897 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1920626: narrow scope of rhsm transient bind mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 26, 2021
@gabemontero
Copy link
Contributor

NOTE: we'll also have to remove https://github.com/openshift/builder/blob/release-4.6/imagecontent/etc/containers/mounts.conf just like we removed that file in master branch/4.7

I'll do that manually vs. using the bot to avoid the creation of an additional bugzilla

@adambkaplan FYI

@gabemontero
Copy link
Contributor

NOTE: we'll also have to remove https://github.com/openshift/builder/blob/release-4.6/imagecontent/etc/containers/mounts.conf just like we removed that file in master branch/4.7

I'll do that manually vs. using the bot to avoid the creation of an additional bugzilla

@adambkaplan FYI

#212 is that PR

@xiuwang
Copy link

xiuwang commented Jan 27, 2021

/bugzilla cc-qa
/lgtm

Trigger build from DPTP bc on cluster launch openshift/builder#211,openshift/builder#212 4.6.0-0.ci.test-2021-01-27-083249-ci-ln-lggblwt , the build passed.
Build with source secret go to complete too.

@openshift-ci-robot
Copy link
Contributor

@xiuwang: This pull request references Bugzilla bug 1920626, which is invalid:

  • expected dependent Bugzilla bug 1916897 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa
/lgtm

Trigger build from DPTP bc on cluster launch openshift/builder#211,openshift/builder#212 4.6.0-0.ci.test-2021-01-27-083249-ci-ln-lggblwt , the build passed.
Build with source secret go to complete too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1920626, which is invalid:

  • expected dependent Bugzilla bug 1916897 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1920626, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1916897 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1916897 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2021
@gabemontero
Copy link
Contributor

/assign @adambkaplan

for approve label

all tests green

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@gabemontero
Copy link
Contributor

/bugzilla refresh

1 similar comment
@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1920626, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1916897 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1916897 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 28, 2021
@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit c0d0a94 into openshift:release-4.6 Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1920626 has not been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1920626: narrow scope of rhsm transient bind mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/cherrypick release-4.5

@openshift-cherrypick-robot
Copy link
Author

@gabemontero: #211 failed to apply on top of branch "release-4.5":

Applying: narrow scope of rhsm transient bind mount; originate it from tmp dir for cases where data can persist
Using index info to reconstruct a base tree...
M	cmd/main.go
M	pkg/build/builder/daemonless.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/build/builder/daemonless.go
Auto-merging cmd/main.go
CONFLICT (content): Merge conflict in cmd/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 narrow scope of rhsm transient bind mount; originate it from tmp dir for cases where data can persist
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants