Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report User/Group ID when they cannot be parsed #276

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Dec 2, 2021

When complaining about not being able to find any ID mapping ranges for the current user, include the user's name in the error message.

When complaining about not being able to find any ID mapping ranges for
the current user, include the user's name in the error message.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@adambkaplan
Copy link
Contributor

/retitle Report User/Group ID when they cannot be parsed

@openshift-ci openshift-ci bot changed the title parseIDMappings(): complain correctly Report User/Group ID when they cannot be parsed Dec 3, 2021
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

/label docs-approved

No docs needed.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Dec 22, 2021
@adambkaplan
Copy link
Contributor

/label px-approved

No product experience needed.

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 22, 2021
@adambkaplan
Copy link
Contributor

/assign @prietyc123 @jitendar-singh

For qe-approval. @nalind is there a Bugzilla issue or other item that can we use to reproduce this issue?

@prietyc123
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2021

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b35ac02 into openshift:master Dec 23, 2021
@nalind nalind deleted the error-message-message branch January 5, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants