Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial workflow (OWNERS, etc.) only tracking secondary metadata #2

Closed
wants to merge 22 commits into from

Conversation

wking
Copy link
Member

@wking wking commented Sep 12, 2019

While #1 is currently only updating Quay lables, there has been some concern around it positioning itself to be the single source of Cincinnati graph-builder data at some future point. Since my main goal is to get the release-admin workflow into version control, here's a lighter-weight alternative that only manages secondary metadata. Cincinnati would continue to pull primary metadata dynamically from image release-metadata on Quay, and it would get overrides from this repository.

For at least the short term, those overrides would be set in Quay labels just like they are today; we might change that later, but it wouldn't affect the release-admin workflow.

There's also been pushback against hand-edited JSON in #1. But I'm lazy and want these scripts to work even for folks without PyYAML installed ;). We can switch to YAML easily later if folks are comfortable with the workflow.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2019
@wking wking changed the title Initial workflow (OWNERS, etc.) only tracking secondary metadata WIP: Initial workflow (OWNERS, etc.) only tracking secondary metadata Sep 12, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2019
@steveej
Copy link
Contributor

steveej commented Sep 16, 2019

Thanks @wking, this is much like what I originally had in mind. Ideally I would've liked if pushing the tags could've happened from CI which we have deemed to risky for now in an out-of-band discussion.

Which brings me to the most interesting part of the validation rules when to enforce them.
We can't rule out that someone accidentally pushes the tags without going through CI and review first, so we have to enforce at push-time.
The one rule we have discussed so far, which IIUC has lead to this PR is:

  • graph.release.channels must be append only, as we never want a release removed from a channel.
    We might want an override flag which takes the rule-name for exceptional cases.

We have a quay v1 API client over at cincinnati. It also has support for token authentication and fetching the labels. It'd be great to extend that with pushing labels.

Alex did this ~two hours ago.  Generated with:

  $ hack/pull
Generated with:

  $ hack/pull
Alex did this ~two hours ago.  Generated with:

  $ hack/pull
Alex just did this.  Generated with:

  $ hack/pull
Alex just did this.  Generated with:

  $ hack/pull
Someone did this within the past few hours ;).  Generated with:

  $ hack/pull
Clayton just did this.  Generated with:

  $ hack/pull
I'm catching up after a few days; I'm not actually sure when this
happened.  Generated with:

  $ hack/pull
Clayton tagged these in 20 minutes ago.
I haven't tracked down when it was tagged into prerelease, but Jessica
tagged it into stable on 2019-10-15T17:22Z.
I haven't tracked down the earlier channels, but the stable-4.2 tag
was Jessica eight hours ago.  Generated with:

  $ hack/pull
…te-4.2

We left 4.2.0->4.2.1 out of the 4.2.1 metadata, so cut 4.2.2 with the
same payload excepting the fixed previous-version metadata.
Lots of changes.  I haven't been paying enough attention to comment on
who/when/why.  Generated with:

  $ hack/pull
4.2.11 failed promotion, and we couldn't figure out how to retest.  We
rebuilt it as 4.1.12, but accidentally tagged 4.2.11 into channels.
Remove the incoming edges, and we'll add an off-ramp for
4.2.11->4.2.14.
@wking
Copy link
Member Author

wking commented Jan 3, 2020

replaced by #4.

/close

@openshift-ci-robot
Copy link

@wking: Closed this PR.

In response to this:

replaced by #4.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the secondary-metadata-only branch January 3, 2020 19:38
@openshift-ci-robot
Copy link

@wking: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
3 participants