in the event that the secret for a CR is missing, re-reconcile #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the case where the credRequest has previously been provisioned, but then the secret holding the creds (cr.Spec.SecretRef) has been deleted. detect this case, and cause a re-reconcile even if the credRequest has recently been synced add/update test cases
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
dgoodwin
reviewed
Oct 28, 2019
| } | ||
|
|
||
| isStale := cr.Generation != cr.Status.LastSyncGeneration | ||
| hasRecentlySynced := cr.Status.LastSyncTimestamp != nil && cr.Status.LastSyncTimestamp.Add(time.Hour*1).After(time.Now()) | ||
|
|
||
| if !isStale && hasRecentlySynced { | ||
| if !isStale && hasRecentlySynced && crSecretExists { |
There was a problem hiding this comment.
Aha so we were watching secret deletions and this probably worked at one point, but the logic changed and it was getting skipped if recently synced.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the case where the credRequest has previously been provisioned, but then the secret holding the creds (cr.Spec.SecretRef) has been deleted.
detect this case, and cause a re-reconcile even if the credRequest has recently been synced
add/update test cases