New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1846200: make AWS_POD_IDENTITY_WEBHOOK_IMAGE not set non-fatal #209
Conversation
@sjenning: This pull request references Bugzilla bug 1846200, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Tested on 4.4 and we can now startup cleanly there which is great.
Could/should we lump that into this fix? |
@dgoodwin that error should resolve when the limited |
@dgoodwin The s3 limited cred that controller uses was added to |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sjenning: All pull requests linked via external trackers have merged: openshift/cloud-credential-operator#209. Bugzilla bug 1846200 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dgoodwin @abhinavdahiya @wking
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1846200
This changes the behavior from fatal termination of the whole operator when
AWS_POD_IDENTITY_WEBHOOK_IMAGE
is not set, to just disabling thepodidentitywebhook
controller within the operator.