Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown #267

Merged
merged 1 commit into from Nov 16, 2020
Merged

Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown #267

merged 1 commit into from Nov 16, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #262

/assign wking

@wking
manifests: Allow 'for: 20m' for CloudCredentialOperatorDown
1e60d55 
The alert was born with a 5m 'for' as CCOperatorDown in 63af2de
(add alert for when operator is down, 2019-10-28, openshift#132).  But folks
are unlikely to be churning their creds so quickly that the occasional
longer operator outage is worth waking an admin with a midnight alarm.
This is true in general, although folks have been revisiting this
alert in the context of 4.5->4.6 updates, where a shift in leader
leasing has lead to a risk of an 8 minute delay as a 4.6 operator
waits patiently before picking up a lease abandoned by a 4.5 operator
[1].  The new 20m threshold allows for two such delays with room to
spare, and also ensures we aren't waking folks up if theres a brief
network or registry outage while pods are being rescheduled or
anything minor like that.  Some things are worth more agressive
thresholds, but I don't think the cred operator is one of them.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1889540#c4
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 10, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1889540 has been cloned as Bugzilla bug 1896230. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

In response to this:

[release-4.6] Bug 1889540: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1889540: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown [release-4.6] Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown Nov 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896230, which is invalid:

  • expected dependent Bugzilla bug 1889540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Nov 10, 2020

/retitle Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown Nov 10, 2020
@wking
Copy link
Member

wking commented Nov 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@twiest twiest removed their request for review November 10, 2020 17:57
@dgoodwin
Copy link
Collaborator

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1896230, which is invalid:

  • expected dependent Bugzilla bug 1889540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1896230, which is invalid:

  • expected dependent Bugzilla bug 1889540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Nov 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1896230, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1889540 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1889540 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 12, 2020
@wking
Copy link
Member

wking commented Nov 12, 2020

/cherrypick release-4.5

@openshift-cherrypick-robot
Copy link
Author

@wking: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit f6027aa into openshift:release-4.6 Nov 16, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1896230 has been moved to the MODIFIED state.

In response to this:

Bug 1896230: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@wking: #267 failed to apply on top of branch "release-4.5":

Applying: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown
Using index info to reconstruct a base tree...
A	manifests/0000_90_cloud-credential-operator_04_alertrules.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): manifests/0000_90_cloud-credential-operator_04_alertrules.yaml deleted in HEAD and modified in manifests: Allow 'for: 20m' for CloudCredentialOperatorDown. Version manifests: Allow 'for: 20m' for CloudCredentialOperatorDown of manifests/0000_90_cloud-credential-operator_04_alertrules.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 manifests: Allow 'for: 20m' for CloudCredentialOperatorDown
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelddiaz joelddiaz Awaiting requested review from joelddiaz

Assignees

@dgoodwin dgoodwin

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @wking @dgoodwin @openshift-bot @sdodson @openshift-merge-robot