Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1898199: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown #269

Merged
merged 1 commit into from Dec 2, 2020
Merged

Bug 1898199: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown #269

merged 1 commit into from Dec 2, 2020

Conversation

wking
Copy link
Member

@wking wking commented Nov 16, 2020

Picking #267 back to 4.5.

@wking
manifests: Allow 'for: 20m' for CloudCredentialOperatorDown
ae852c1 
The alert was born with a 5m 'for' as CCOperatorDown in 63af2de
(add alert for when operator is down, 2019-10-28, openshift#132).  But folks
are unlikely to be churning their creds so quickly that the occasional
longer operator outage is worth waking an admin with a midnight alarm.
This is true in general, although folks have been revisiting this
alert in the context of 4.5->4.6 updates, where a shift in leader
leasing has lead to a risk of an 8 minute delay as a 4.6 operator
waits patiently before picking up a lease abandoned by a 4.5 operator
[1].  The new 20m threshold allows for two such delays with room to
spare, and also ensures we aren't waking folks up if theres a brief
network or registry outage while pods are being rescheduled or
anything minor like that.  Some things are worth more agressive
thresholds, but I don't think the cred operator is one of them.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1889540#c4
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1898199, which is invalid:

  • expected dependent Bugzilla bug 1896230 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1889540 to target a release in 4.6.0, 4.6.z, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1898199: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Nov 23, 2020

/bugzilla refresh
/assign @dgoodwin

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 23, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1898199, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896230 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1896230 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh
/assign @dgoodwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 371eb00 into openshift:release-4.5 Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: All pull requests linked via external trackers have merged:

Bugzilla bug 1898199 has been moved to the MODIFIED state.

In response to this:

Bug 1898199: manifests: Allow 'for: 20m' for CloudCredentialOperatorDown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@joelddiaz joelddiaz Awaiting requested review from joelddiaz

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wking @openshift-ci-robot @dgoodwin @sdodson @openshift-merge-robot