Bug 1996624: Check for aws status in infra platform status field before client setup #399
Conversation
We use aws as default implementation for secret annotator. This causes panic if aws status is nil in infrastucture.Status.PlatformStatus field.
|
@akhil-rane: This pull request references Bugzilla bug 1996624, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-unspecified
|
/assign @joelddiaz |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@akhil-rane: This pull request references Bugzilla bug 1996624, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 46.96% 47.41% +0.44%
==========================================
Files 82 82
Lines 8281 8363 +82
==========================================
+ Hits 3889 3965 +76
- Misses 3892 3899 +7
+ Partials 500 499 -1
|
|
Test pass using image with the PR merged.
$ oc get pods NAME READY STATUS RESTARTS AGE cloud-credential-operator-64bd974b87-phdqf 2/2 Running 0 6h45m $ oc logs cloud-credential-operator-64bd974b87-phdqf -c cloud-credential-operator | grep "observed admin cloud credential secret event" time="2021-10-12T01:53:21Z" level=info msg="observed admin cloud credential secret event" namespace=kube-system secret=openstack-credentials time="2021-10-12T07:10:12Z" level=info msg="observed admin cloud credential secret event" namespace=kube-system secret=aws-creds time="2021-10-12T07:21:43Z" level=info msg="observed admin cloud credential secret event" namespace=kube-system secret=gcp-credentials time="2021-10-12T07:31:49Z" level=info msg="observed admin cloud credential secret event" namespace=kube-system secret=azure-credentials time="2021-10-12T07:46:06Z" level=info msg="observed admin cloud credential secret event" namespace=kube-system secret=vsphere-creds /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhil-rane, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@akhil-rane: All pull requests linked via external trackers have merged: Bugzilla bug 1996624 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@akhil-rane: new pull request created: #405 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@joelddiaz: Bugzilla bug 1996624 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@akhil-rane: new pull request created: #427 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@akhil-rane: new pull request created: #430 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We go for aws, if secret annotator implementation does not exist for a cloud
platform. The current code causes panic while doing aws client setup for
non-aws platform. This commit fixes it.