[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup #405

openshift-cherrypick-robot · 2021-10-20T14:39:40Z

This is an automated cherry-pick of #399

/assign akhil-rane

We use aws as default implementation for secret annotator. This causes panic if aws status is nil in infrastucture.Status.PlatformStatus field.

akhil-rane

/lgtm

openshift-ci · 2021-10-20T14:43:53Z

@openshift-cherrypick-robot: Bugzilla bug 1996624 has been cloned as Bugzilla bug 2015989. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup

In response to this:

[release-4.9] Bug 1996624: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-20T14:46:01Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2015989, which is invalid:

expected dependent Bugzilla bug 1996624 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 1996624 to target a release in 4.10.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2021-10-20T15:14:20Z

Codecov Report

Merging #405 (30e9777) into release-4.9 (0d83e9b) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           release-4.9     #405   +/-   ##
============================================
  Coverage        46.03%   46.03%           
============================================
  Files               74       74           
  Lines             7755     7755           
============================================
  Hits              3570     3570           
  Misses            3691     3691           
  Partials           494      494

Impacted Files	Coverage Δ
pkg/operator/utils/aws/utils.go	`45.23% <100.00%> (ø)`

akhil-rane · 2021-10-20T15:40:36Z

/bugzilla refresh

openshift-ci · 2021-10-20T15:41:40Z

@akhil-rane: This pull request references Bugzilla bug 2015989, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead
expected dependent Bugzilla bug 1996624 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-21T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-21T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 2015989, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead
expected dependent Bugzilla bug 1996624 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lwan-wanglin · 2021-10-21T02:34:41Z

/bugzilla refresh

openshift-ci · 2021-10-21T02:34:49Z

@lwan-wanglin: This pull request references Bugzilla bug 2015989, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1996624 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1996624 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @lwan-wanglin

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lwan-wanglin · 2021-10-21T12:24:14Z

/label qe-approved

Verified steps in bug https://bugzilla.redhat.com/show_bug.cgi?id=2015989#c2

akhil-rane · 2021-11-22T21:09:56Z

/approve

akhil-rane · 2021-11-22T21:10:15Z

/label backport-risk-assessed

joelddiaz · 2021-11-22T21:47:16Z

/approve

openshift-ci · 2021-11-22T21:54:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-22T22:13:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-22T22:25:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

lwan-wanglin · 2021-11-23T01:12:39Z

/label cherry-pick-approved

openshift-ci · 2021-11-23T01:12:40Z

@lwan-wanglin: The label(s) /label lgtm cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label cherry-pick-approved
/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-23T01:13:36Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#405

Bugzilla bug 2015989 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akhil-rane · 2021-11-23T18:31:07Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-11-23T18:31:50Z

@akhil-rane: new pull request created: #425

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp · 2021-11-24T22:24:29Z

/cherry-pick release-4.8

@akhil-rane, patchmanager here. I suggest cherry picking from the original PR given cherry picking from here will result in a [release-4.8][release4.9] prefix which threw off for a bit. It made it seem #425 was targeted at 4.9 and 4.8.

Check for aws status in infra platform status field before client setup

30e9777

We use aws as default implementation for secret annotator. This causes panic if aws status is nil in infrastucture.Status.PlatformStatus field.

openshift-cherrypick-robot mentioned this pull request Oct 20, 2021

Bug 1996624: Check for aws status in infra platform status field before client setup #399

Merged

akhil-rane reviewed Oct 20, 2021

View reviewed changes

openshift-ci bot assigned akhil-rane Oct 20, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021

openshift-ci bot changed the title ~~[release-4.9] Bug 1996624: Check for aws status in infra platform status field before client setup~~ [release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup Oct 20, 2021

openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 20, 2021

openshift-ci bot requested review from joelddiaz and twiest October 20, 2021 14:50

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 21, 2021

openshift-ci bot requested a review from lwan-wanglin October 21, 2021 02:34

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 21, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 22, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 23, 2021

openshift-merge-robot merged commit 382e3f0 into openshift:release-4.9 Nov 23, 2021

openshift-cherrypick-robot mentioned this pull request Nov 23, 2021

[release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup #425

Merged

akhil-rane mentioned this pull request Nov 30, 2021

[release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup #427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup #405

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup #405

openshift-cherrypick-robot commented Oct 20, 2021

akhil-rane left a comment

openshift-ci bot commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

codecov bot commented Oct 20, 2021 •

edited

akhil-rane commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

openshift-bot commented Oct 21, 2021

openshift-ci bot commented Oct 21, 2021

lwan-wanglin commented Oct 21, 2021

openshift-ci bot commented Oct 21, 2021

lwan-wanglin commented Oct 21, 2021

akhil-rane commented Nov 22, 2021

akhil-rane commented Nov 22, 2021

joelddiaz commented Nov 22, 2021

openshift-ci bot commented Nov 22, 2021

openshift-bot commented Nov 22, 2021

openshift-bot commented Nov 22, 2021

lwan-wanglin commented Nov 23, 2021 •

edited

openshift-ci bot commented Nov 23, 2021

openshift-ci bot commented Nov 23, 2021

akhil-rane commented Nov 23, 2021

openshift-cherrypick-robot commented Nov 23, 2021

aravindhp commented Nov 24, 2021

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup #405

[release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup #405

Conversation

openshift-cherrypick-robot commented Oct 20, 2021

akhil-rane left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

codecov bot commented Oct 20, 2021 • edited

Codecov Report

akhil-rane commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

openshift-bot commented Oct 21, 2021

openshift-ci bot commented Oct 21, 2021

lwan-wanglin commented Oct 21, 2021

openshift-ci bot commented Oct 21, 2021

lwan-wanglin commented Oct 21, 2021

akhil-rane commented Nov 22, 2021

akhil-rane commented Nov 22, 2021

joelddiaz commented Nov 22, 2021

openshift-ci bot commented Nov 22, 2021

openshift-bot commented Nov 22, 2021

openshift-bot commented Nov 22, 2021

lwan-wanglin commented Nov 23, 2021 • edited

openshift-ci bot commented Nov 23, 2021

openshift-ci bot commented Nov 23, 2021

akhil-rane commented Nov 23, 2021

openshift-cherrypick-robot commented Nov 23, 2021

aravindhp commented Nov 24, 2021

codecov bot commented Oct 20, 2021 •

edited

lwan-wanglin commented Nov 23, 2021 •

edited