Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup #425

Merged
merged 1 commit into from Nov 29, 2021
Merged

[release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup #425

merged 1 commit into from Nov 29, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #405

/assign akhil-rane

@akhil-rane
Check for aws status in infra platform status field before client setup
6a16b82 
We use aws as default implementation for secret annotator. This
causes panic if aws status is nil in infrastucture.Status.PlatformStatus
field.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 23, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@openshift-cherrypick-robot: Bugzilla bug 2015989 has been cloned as Bugzilla bug 2026098. Retitling PR to link against new bug.
/retitle [release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup

In response to this:

[release-4.8] [release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] [release-4.9] Bug 2015989: Check for aws status in infra platform status field before client setup [release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup Nov 23, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2026098, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2015989 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2015989 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @lwan-wanglin

In response to this:

[release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhil-rane
Copy link
Contributor

@joelddiaz please take a look

@joelddiaz
Copy link
Contributor

/approve
/backport-risk-assesed

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@lwan-wanglin
Copy link

Verified steps paste in Bug 2026098#c1

/label cherry-pick-approved
/label qe-approved
/lgtm

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Nov 24, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, lwan-wanglin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@akhil-rane
Copy link
Contributor

/label backport-risk-assesed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

@akhil-rane: The label(s) /label backport-risk-assesed cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label backport-risk-assesed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhil-rane
Copy link
Contributor

/backport-risk-assessed

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@aravindhp
Copy link
Member

/backport-risk-assessed

@akhil-rane, patchmanager here. This should be /label backport-risk-assessed

@akhil-rane
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit b81033d into openshift:release-4.8 Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2026098 has been moved to the MODIFIED state.

In response to this:

[release-4.8] [release-4.9] Bug 2026098: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwan-wanglin lwan-wanglin Awaiting requested review from lwan-wanglin

@csrwng csrwng Awaiting requested review from csrwng

@twiest twiest Awaiting requested review from twiest

Assignees

@akhil-rane akhil-rane

@lwan-wanglin lwan-wanglin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @akhil-rane @joelddiaz @lwan-wanglin @openshift-bot @aravindhp @openshift-merge-robot