Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup #427

Merged
merged 1 commit into from Dec 2, 2021
Merged

[release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup #427

merged 1 commit into from Dec 2, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #399

/assign akhil-rane

@akhil-rane
Check for aws status in infra platform status field before client setup
d45216a 
We use aws as default implementation for secret annotator. This
causes panic if aws status is nil in infrastucture.Status.PlatformStatus
field.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 30, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

@openshift-cherrypick-robot: Bugzilla bug 1996624 has been cloned as Bugzilla bug 2027750. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup

In response to this:

[release-4.7] Bug 1996624: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1996624: Check for aws status in infra platform status field before client setup [release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup Nov 30, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2027750, which is invalid:

  • expected dependent Bugzilla bug 1996624 to target a release in 4.8.0, 4.8.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 30, 2021
@akhil-rane
Copy link
Contributor

/approve

@akhil-rane
Copy link
Contributor

akhil-rane commented Nov 30, 2021 •
edited

  • expected dependent Bugzilla bug 1996624 to target a release in 4.8.0, 4.8.z, but it targets "4.10.0" instead

@aravindhp as suggested by you here, I tried to backport from master but looks like the bot is not happy. IIUC the bot expects cherry pick from 4.8 PR. Am I missing something here?

@aravindhp
Copy link
Member

No the bot does not expect a cherry-pick from 4.8 but rather the BZs all need to be matched up correctly and in the correct state with correct versions.

expected dependent Bugzilla bug 1996624 to target a release in 4.8.0, 4.8.z, but it targets "4.10.0" instead

So it might be that the dependency graph is messed up here.

@aravindhp
Copy link
Member

Bugzilla bug 2027750 needs to be blocked by the 4.9 BZ and not the 4.10 BZ. The cherry-pick bot usually handles this cleanly. At least that has been my experience when opening all cherry-picks from the master PR.

@akhil-rane
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

@akhil-rane: This pull request references Bugzilla bug 2027750, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2026098 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2026098 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @lwan-wanglin

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 30, 2021
@akhil-rane
Copy link
Contributor

No the bot does not expect a cherry-pick from 4.8 but rather the BZs all need to be matched up correctly and in the correct state with correct versions.

expected dependent Bugzilla bug 1996624 to target a release in 4.8.0, 4.8.z, but it targets "4.10.0" instead

So it might be that the dependency graph is messed up here.

looks like bot is happy now

akhil-rane
akhil-rane reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@akhil-rane
Copy link
Contributor

@joelddiaz needs approve

@akhil-rane
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 30, 2021
@akhil-rane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@joelddiaz
Copy link
Contributor

/approved

@joelddiaz
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@lwan-wanglin
Copy link

Verified steps are in Bug 2027750#c1
/label cherry-pick-approved
/label qe-approved
/lgtm

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Dec 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit e4c8b05 into openshift:release-4.7 Dec 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2027750 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2027750: Check for aws status in infra platform status field before client setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz, lwan-wanglin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhil-rane akhil-rane akhil-rane left review comments

@csrwng csrwng Awaiting requested review from csrwng

@joelddiaz joelddiaz Awaiting requested review from joelddiaz

@lwan-wanglin lwan-wanglin Awaiting requested review from lwan-wanglin

Assignees

@akhil-rane akhil-rane

@lwan-wanglin lwan-wanglin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @akhil-rane @aravindhp @joelddiaz @lwan-wanglin @openshift-merge-robot