Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1727012: add upgradeable condition unconditionally #88

Merged
merged 1 commit into from Jul 15, 2019
Merged

Bug 1727012: add upgradeable condition unconditionally #88

merged 1 commit into from Jul 15, 2019

Conversation

joelddiaz
Copy link
Contributor

operators should report upgradeability. add upgradeable status when calculating clusteroperator status

addresses BZ https://bugzilla.redhat.com/show_bug.cgi?id=1727012

@joelddiaz joelddiaz requested a review from dgoodwin July 10, 2019 19:31
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 10, 2019
@openshift-ci-robot
Copy link
Contributor

@joelddiaz: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1727012: add upgradeable condition unconditionally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@dgoodwin
Copy link
Collaborator

/lgtm

What is up with CI lately?

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@dgoodwin
Copy link
Collaborator

Conflicts :(

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@dgoodwin
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@joelddiaz
Copy link
Contributor Author

/test e2e-aws

2 similar comments
@joelddiaz
Copy link
Contributor Author

/test e2e-aws

@joelddiaz
Copy link
Contributor Author

/test e2e-aws

@joelddiaz
Copy link
Contributor Author

/retest

1 similar comment
@joelddiaz
Copy link
Contributor Author

/retest

twiest
twiest approved these changes Jul 15, 2019
View reviewed changes
Copy link

@twiest twiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz, twiest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgoodwin,joelddiaz,twiest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8b57f67 into openshift:master Jul 15, 2019
@openshift-ci-robot
Copy link
Contributor

@joelddiaz: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1727012: add upgradeable condition unconditionally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelddiaz joelddiaz deleted the upgradeable branch June 16, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiest twiest twiest approved these changes

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

@dgoodwin dgoodwin

@twiest twiest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joelddiaz @openshift-ci-robot @dgoodwin @twiest @openshift-merge-robot