New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-aws:master into master #22
Conversation
Use go-runner as base image
Tag on create
* Add changelog. * Add entry to README table. * Rewrite release instructions. * Update helm workflow to run on release branches.
Release v1.23.0-alpha.0
Update charts for v1.23.0-alpha.0
Apiserver would not allow multiple nodes with the same name, so for external CCM, this test is not needed
External CCM never fetch data from metadata, so this test is redundant.
External cloud controller should never use metadata to determine addresses. We only forward this call to satisfy the interface.
Remove metadata funcs
- Use ginkgo binary to run the tests for now instead of using the kops kubetest2 tester. We can improve this once we have the ability to run arbitrary e2e.test binaries with the kops tester.
E2E framework
* Create test run directory earlier to avoid failure * Install e2e prereqs
Get e2e tests working in prow
* Don't tag Fargate nodes * Label nodes to prevent retagging them again * Increase bucket size for latency metrics
[FIXES] [Tagging Controller] Fix issues in tagging controller
Tag releases automatically
Fetch all history when tagging releases
Generated by `go mod vendor`
|
@Fedosin: This pull request references Bugzilla bug 2087042, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Fedosin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Fedosin: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2087042 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.