Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-aws:master into master #22

Merged
merged 131 commits into from Jun 2, 2022

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Jun 1, 2022

No description provided.

Ole Markus With and others added 30 commits December 8, 2021 13:43
* Add changelog.
* Add entry to README table.
* Rewrite release instructions.
* Update helm workflow to run on release branches.
Apiserver would not allow multiple nodes with the same name, so for
external CCM, this test is not needed
External CCM never fetch data from metadata, so this test is redundant.
External cloud controller should never use metadata to determine addresses.
We only forward this call to satisfy the interface.
- Use ginkgo binary to run the tests for now instead of using the kops
kubetest2 tester.  We can improve this once we have the ability to run
arbitrary e2e.test binaries with the kops tester.
* Create test run directory earlier to avoid failure
* Install e2e prereqs
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@Fedosin: This pull request references Bugzilla bug 2087042, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-aws:master into master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@Fedosin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ccm-install 0c8f4e6 link false /test e2e-aws-ccm-install

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit bd159fb into openshift:master Jun 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

@Fedosin: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2087042 has not been moved to the MODIFIED state.

In response to this:

Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-aws:master into master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet