Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ose-azure-cloud-node-manager images to be consistent with ART #14

Conversation

openshift-bot
Copy link

@openshift-bot openshift-bot commented Sep 15, 2021

Updating ose-azure-cloud-node-manager images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. bugzilla/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-azure-cloud-node-manager.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #aos-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-bot openshift-bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 15, 2021
@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.10-ose-azure-cloud-node-manager branch from 04947d2 to 1fa2d72 Compare September 16, 2021 11:28
@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f38815f into openshift:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants