Bug 2087042: Merge https://github.com/kubernetes-sigs/cloud-provider-azure:master into master #31
Conversation
…llback_protocol Fix: fallback to tcp if appprotocol is not supported
Bumps [github.com/Azure/go-autorest/autorest/mocks](https://github.com/Azure/go-autorest) from 0.4.1 to 0.4.2. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/mocks/v0.4.1...autorest/mocks/v0.4.2) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest/mocks dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/github.com/Azure/go-autorest/autorest/mocks-0.4.2 chore(deps): bump github.com/Azure/go-autorest/autorest/mocks from 0.4.1 to 0.4.2
…ient-tests Refactor azure_armclient tests
Cloudbuild used to serially build cloud-controller-manager and cloud-node-manager images, which takes too much time. Now, with variants.yaml, cloudbuild builds both images in parallel. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
…riants Reduce build time for cloudbuild
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
…ache_enchancement Rollback pr kubernetes-sigs#1300 Refactor store and use sync.map as data store
Add List() to pls client interface
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest) from 0.11.24 to 0.11.25. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/v0.11.24...autorest/v0.11.25) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/github.com/Azure/go-autorest/autorest-0.11.25 chore(deps): bump github.com/Azure/go-autorest/autorest from 0.11.24 to 0.11.25
Bumps [github.com/Azure/azure-sdk-for-go](https://github.com/Azure/azure-sdk-for-go) from 63.0.0+incompatible to 63.1.0+incompatible. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/CHANGELOG.md) - [Commits](Azure/azure-sdk-for-go@v63.0.0...v63.1.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/github.com/Azure/azure-sdk-for-go-63.1.0incompatible chore(deps): bump github.com/Azure/azure-sdk-for-go from 63.0.0+incompatible to 63.1.0+incompatible
…nt-client-subs chore: add subsID parameter in storage account client
…rReal-patch-2 Docs: health probe works only on out of tree provider
* update installation and configuration parts * add uninstallation part Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
…lated [helm] Update helm doc
* Frontend PIP config name may end with invalid char like '-' * Add a UT and update an e2e testcase Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/github_actions/actions/setup-go-3 chore(deps): bump actions/setup-go from 2 to 3
…ot/github_actions/actions/upload-artifact-3 chore(deps): bump actions/upload-artifact from 2 to 3
…ot/github_actions/actions/download-artifact-3 chore(deps): bump actions/download-artifact from 2 to 3
* ignore README.md when verifying helm repo * support make update-helm Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
Delete .github directory entirely since we do not want to use GH workflows, templates, dependabot etc in ocp fork. # Conflicts: # .github/dependabot.yml # .github/workflows/gh-pages.yaml # .github/workflows/test-docs.yaml
The Makefile sets GOARCH?=amd64, which needs to be overridden for this image to build properly on other architectures.
* use -mod=readonly to fetch golangci-lint binary * remove "fmt" and "vet" targets from our custom "verify" job, as they were removed in upstream by kubernetes-sigs#1314
openshift-ci
bot
added
bugzilla/severity-high
|
@Fedosin: This pull request references Bugzilla bug 2087042, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Fedosin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Fedosin is the broken git-history test a known issue for this repo when doing the rebase? |
|
i notice we have a merge commit as the latest here, but in the aws rebase we don't. see https://github.com/openshift/cloud-provider-aws/pull/22/commits |
|
Yeah, verify-git-history is expected to fail on such rebases... Merge commit was added to fix github's conflicts when merging the rebase PR. |
|
/test e2e-azure-ccm |
|
thanks Mike! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Fedosin: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2087042 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.