Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-gcp:master into master #13
Conversation
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
Add verify-vendor.sh. Add vendor verification into presubmit checking.
Ran: go mod tidy && ./tools/update_vendor.sh && ./tools/update_bazel.sh
Bump cloud-provider-gcp to k8s v1.23
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add verify-vendor
Also: * some random cleanup to make the code a bit more go idiomatic. * let gcloud stderr go to stderr. it's forwarded from the parent. * don't spit out stdout from gcloud when we error because it could contain secrets.
i.e. has a token and expiry
add support for authorization tokens to gke-gcloud-auth-plugin
Remove unused code path in cluster/gce/util.sh
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
593c7c0
to
029149f
Compare
Add logic to allow gke-gcloud-auth-plugin to
cache gcloud credentials in the gke-gcloud-auth-plugin-token
file which will be colocated in the same directory as the
kubeconfig file.
The caching logic utilizes clientcmd("k8s.io/client-go/tools/clientcmd")
library provided methods in client-go to location .kube directory.
Bump version.sh
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
029149f
to
23ec513
Compare
…ewer Add jprzychodzen to OWNERS as reviewer
This change removes the logic where we merge the taints and reapply as a part of the node annotator. The reason to remove this is because we do not want the taints that were removed by the users to get reapplied when the controller restarts. We still apply the last applied taints annotation because the cluster autoscaler relies on it.
Remove taints re-application from node annotator
We need to compile the whole module instead of a single file to make GCP CCM work.
…m rebase # Conflicts: # vendor/github.com/google/go-tpm/tpmutil/BUILD # Conflicts: # vendor/github.com/googleapis/gax-go/v2/BUILD # vendor/golang.org/x/oauth2/google/BUILD # vendor/golang.org/x/oauth2/google/internal/externalaccount/BUILD # vendor/golang.org/x/sys/unix/BUILD # vendor/golang.org/x/sys/windows/BUILD # vendor/google.golang.org/api/internal/gensupport/BUILD # vendor/google.golang.org/api/option/internaloption/BUILD # vendor/google.golang.org/protobuf/types/descriptorpb/BUILD # Conflicts: # vendor/github.com/modern-go/reflect2/BUILD # vendor/golang.org/x/net/idna/BUILD # vendor/golang.org/x/term/BUILD # vendor/k8s.io/apimachinery/pkg/runtime/serializer/json/BUILD # vendor/k8s.io/apimachinery/pkg/util/cache/BUILD # vendor/k8s.io/apimachinery/pkg/util/json/BUILD # vendor/k8s.io/apimachinery/pkg/util/managedfields/BUILD # vendor/k8s.io/apimachinery/pkg/util/net/BUILD # vendor/k8s.io/apimachinery/pkg/util/validation/BUILD # vendor/k8s.io/apimachinery/pkg/util/wait/BUILD # vendor/k8s.io/apiserver/pkg/admission/plugin/namespace/lifecycle/BUILD # vendor/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating/BUILD # vendor/k8s.io/apiserver/pkg/admission/plugin/webhook/validating/BUILD # vendor/k8s.io/apiserver/pkg/apis/apiserver/v1alpha1/BUILD # vendor/k8s.io/apiserver/pkg/apis/apiserver/v1beta1/BUILD # vendor/k8s.io/apiserver/pkg/apis/flowcontrol/bootstrap/BUILD # vendor/k8s.io/apiserver/pkg/audit/BUILD # vendor/k8s.io/apiserver/pkg/authentication/token/cache/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/filterlatency/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/filters/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/handlers/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/internal/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/metrics/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/request/BUILD # vendor/k8s.io/apiserver/pkg/endpoints/responsewriter/BUILD # vendor/k8s.io/apiserver/pkg/registry/generic/BUILD # vendor/k8s.io/apiserver/pkg/registry/generic/registry/BUILD # vendor/k8s.io/apiserver/pkg/server/BUILD # vendor/k8s.io/apiserver/pkg/server/dynamiccertificates/BUILD # vendor/k8s.io/apiserver/pkg/server/egressselector/metrics/BUILD # vendor/k8s.io/apiserver/pkg/server/filters/BUILD # vendor/k8s.io/apiserver/pkg/server/healthz/BUILD # vendor/k8s.io/apiserver/pkg/server/httplog/BUILD # vendor/k8s.io/apiserver/pkg/server/options/BUILD # vendor/k8s.io/apiserver/pkg/server/routes/BUILD # vendor/k8s.io/apiserver/pkg/storage/cacher/BUILD # vendor/k8s.io/apiserver/pkg/storage/etcd3/BUILD # vendor/k8s.io/apiserver/pkg/storage/storagebackend/BUILD # vendor/k8s.io/apiserver/pkg/util/apihelpers/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/debug/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/promise/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/format/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/metrics/BUILD # vendor/k8s.io/apiserver/pkg/util/flowcontrol/request/BUILD # vendor/k8s.io/apiserver/pkg/util/openapi/BUILD # vendor/k8s.io/client-go/applyconfigurations/apps/v1/BUILD # vendor/k8s.io/client-go/applyconfigurations/apps/v1beta1/BUILD # vendor/k8s.io/client-go/applyconfigurations/apps/v1beta2/BUILD # vendor/k8s.io/client-go/applyconfigurations/core/v1/BUILD # vendor/k8s.io/client-go/applyconfigurations/meta/v1/BUILD # vendor/k8s.io/client-go/discovery/fake/BUILD # vendor/k8s.io/client-go/informers/BUILD # vendor/k8s.io/client-go/informers/autoscaling/BUILD # vendor/k8s.io/client-go/informers/flowcontrol/BUILD # vendor/k8s.io/client-go/kubernetes/BUILD # vendor/k8s.io/client-go/kubernetes/fake/BUILD # vendor/k8s.io/client-go/kubernetes/scheme/BUILD # vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/BUILD # vendor/k8s.io/client-go/rest/BUILD # vendor/k8s.io/client-go/tools/cache/BUILD # vendor/k8s.io/client-go/tools/events/BUILD # vendor/k8s.io/client-go/tools/leaderelection/BUILD # vendor/k8s.io/client-go/tools/record/BUILD # vendor/k8s.io/client-go/util/cert/BUILD # vendor/k8s.io/client-go/util/flowcontrol/BUILD # vendor/k8s.io/client-go/util/workqueue/BUILD # vendor/k8s.io/cloud-provider/app/BUILD # vendor/k8s.io/cloud-provider/controllers/node/BUILD # vendor/k8s.io/cloud-provider/controllers/nodelifecycle/BUILD # vendor/k8s.io/cloud-provider/controllers/route/BUILD # vendor/k8s.io/cloud-provider/node/helpers/BUILD # vendor/k8s.io/cloud-provider/options/BUILD # vendor/k8s.io/component-base/cli/flag/BUILD # vendor/k8s.io/component-base/cli/globalflag/BUILD # vendor/k8s.io/component-base/config/BUILD # vendor/k8s.io/component-base/config/v1alpha1/BUILD # vendor/k8s.io/component-base/logs/BUILD # vendor/k8s.io/controller-manager/app/BUILD # vendor/k8s.io/controller-manager/pkg/clientbuilder/BUILD # vendor/k8s.io/kube-openapi/pkg/handler/BUILD # vendor/k8s.io/kubernetes/pkg/controller/BUILD # vendor/k8s.io/kubernetes/pkg/util/taints/BUILD
…m rebase # Conflicts: # vendor/golang.org/x/tools/internal/typeparams/BUILD # vendor/k8s.io/code-generator/cmd/client-gen/BUILD # vendor/k8s.io/code-generator/cmd/deepcopy-gen/BUILD # vendor/k8s.io/code-generator/cmd/informer-gen/BUILD # vendor/k8s.io/code-generator/cmd/lister-gen/BUILD # vendor/k8s.io/code-generator/cmd/register-gen/BUILD # vendor/k8s.io/code-generator/pkg/util/BUILD
…ed by Ingress-GCE
Ran: go mod tidy && ./tools/update_vendor.sh && ./tools/update_bazel.sh
Based on docs for internal loadbalancer here [1], backend services [2] and instances in instance-groups [3], following restrictions apply: - Internal LB can load balance to VMs in same region, but different subnets - Instance groups for the backend service must contain instance of the same subnet - An instance can only belong to one load balanced instance group - It is probably useful use-case to have nodes for the cluster belong to more than one subnet. And the current setup fails to create an internal load balancer with nodes in multiple subnets. This change finds pre-existing instance-groups that ONLY contain instances that belong to the cluster, uses them for the backend service. And only ensures instance-groups for remaining ones. [1] https://cloud.google.com/load-balancing/docs/internal [2] https://cloud.google.com/load-balancing/docs/backend-service#restrictions_and_guidance [3] https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-unmanaged-instances#addinstances Co-authored-by: Abhinav Dahiya <abhinav.dahiya@redhat.com>
…l load balancers"
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
dc5477d
to
676418a
Compare
|
/retest |
|
/retitle Bug 2087042: Merge https://github.com/kubernetes/cloud-provider-gcp:master into master |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@cloud-team-rebase-bot[bot]: This pull request references Bugzilla bug 2087042, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@cloud-team-rebase-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@cloud-team-rebase-bot[bot]: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2087042 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.