Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.23 into master #17

Merged
merged 12 commits into from Nov 16, 2021
Merged

Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.23 into master #17

merged 12 commits into from Nov 16, 2021

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

@iksrochpub
Automated repo sync 20211027
058c8e3 
Update module github.com/IBM/vpc-go-sdk to v0.13.0 (#2113)
Update module github.com/IBM/go-sdk-core/v5 to v5.7.1 (#2112)
@iksrochpub
Automated repo sync 20211028
5c7bccf 
Update module github.com/IBM/go-sdk-core/v5 to v5.7.2 (#2114)
@iksrochpub
Automated repo sync 20211029
165b4aa 
Branch release-1.23 CCM image updated (#2115)
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2021

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 1, 2021
@openshift-ci openshift-ci bot requested review from elmiko and lobziik November 1, 2021 12:17
@JoelSpeed JoelSpeed mentioned this pull request Nov 2, 2021
Closed
@iksrochpub
Automated repo sync 20211104
7251cdb 
Update community to v0.23.0-alpha.4 (#2160)
Update from v1.23.0-alpha.3 to v1.23.0-alpha.4 (#2159)
@iksrochpub
Automated repo sync 20211110
6122617 
Update armada-lb main.go per changes in kube sample (#2164)
Update module github.com/IBM/go-sdk-core/v5 to v5.8.0 (#2170)
@iksrochpub
Automated repo sync 20211112
ae5aeda 
Unset envars used for retrieving kube config (#2172)
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@Fedosin
Copy link

Fedosin commented Nov 15, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2021
@cjschaef cjschaef mentioned this pull request Nov 15, 2021
Merged
@cjschaef
Copy link
Member

/retest

@cjschaef
Copy link
Member

We require this change to fix the images check (more specifically, the Dockerfile build), since it still uses golang 1.17
#28

@JoelSpeed
Copy link

/test all

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6be6f8e into openshift:master Nov 16, 2021
@JoelSpeed JoelSpeed deleted the rebase-bot-master branch November 16, 2021 18:35
@JoelSpeed JoelSpeed restored the rebase-bot-master branch November 16, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fedosin @cjschaef @JoelSpeed @openshift-merge-robot @iksrochpub